You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by "Harsh J (Created) (JIRA)" <ji...@apache.org> on 2011/12/11 20:56:40 UTC
[jira] [Created] (ZOOKEEPER-1326) The CLI commands "delete" and
"rmr" are confusing. Can we have "rm" + "rmr" instead?
The CLI commands "delete" and "rmr" are confusing. Can we have "rm" + "rmr" instead?
------------------------------------------------------------------------------------
Key: ZOOKEEPER-1326
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1326
Project: ZooKeeper
Issue Type: Wish
Components: java client
Affects Versions: 3.4.0
Reporter: Harsh J
Priority: Trivial
ZOOKEEPER-729 introduced 'rmr' for recursive 'delete' operations on a given node. Going by the unix convention, wouldn't it be much better if we were to have an 'rm' if there was an 'rmr' added?
The current set is confusing. Or should we have 'delete' and 'deleteall' or summat?
I know this is a nitpick, but I just dislike to see bad keywords used for commands.
I'm OK to produce a backwards-compatible patch if this is acceptable.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ZOOKEEPER-1326) The CLI commands "delete" and
"rmr" are confusing. Can we have "rm" + "rmr" instead?
Posted by "Harsh J (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1326?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Harsh J updated ZOOKEEPER-1326:
-------------------------------
Attachment: ZOOKEEPER-1326.patch
Patch that changes 'rmr' to 'deleteall' instead.
This is more consistent with the API call {{ZooKeeper#delete}}.
Also changes the tests to parse commands, like testDelete does, and adds a documentation line for this new command that was not previously added.
> The CLI commands "delete" and "rmr" are confusing. Can we have "rm" + "rmr" instead?
> ------------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-1326
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1326
> Project: ZooKeeper
> Issue Type: Wish
> Components: java client
> Affects Versions: 3.4.0
> Reporter: Harsh J
> Priority: Trivial
> Attachments: ZOOKEEPER-1326.patch, ZOOKEEPER-1326.patch
>
>
> ZOOKEEPER-729 introduced 'rmr' for recursive 'delete' operations on a given node. Going by the unix convention, wouldn't it be much better if we were to have an 'rm' if there was an 'rmr' added?
> The current set is confusing. Or should we have 'delete' and 'deleteall' or summat?
> I know this is a nitpick, but I just dislike to see bad keywords used for commands.
> I'm OK to produce a backwards-compatible patch if this is acceptable.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1326) The CLI commands "delete" and
"rmr" are confusing. Can we have "rm" + "rmr" instead?
Posted by "Mahadev konar (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13167195#comment-13167195 ]
Mahadev konar commented on ZOOKEEPER-1326:
------------------------------------------
@Harsh,
Good point. A backwards compatible patch is welcome.
> The CLI commands "delete" and "rmr" are confusing. Can we have "rm" + "rmr" instead?
> ------------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-1326
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1326
> Project: ZooKeeper
> Issue Type: Wish
> Components: java client
> Affects Versions: 3.4.0
> Reporter: Harsh J
> Priority: Trivial
>
> ZOOKEEPER-729 introduced 'rmr' for recursive 'delete' operations on a given node. Going by the unix convention, wouldn't it be much better if we were to have an 'rm' if there was an 'rmr' added?
> The current set is confusing. Or should we have 'delete' and 'deleteall' or summat?
> I know this is a nitpick, but I just dislike to see bad keywords used for commands.
> I'm OK to produce a backwards-compatible patch if this is acceptable.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ZOOKEEPER-1326) The CLI commands "delete" and
"rmr" are confusing. Can we have "rm" + "rmr" instead?
Posted by "Harsh J (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1326?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Harsh J updated ZOOKEEPER-1326:
-------------------------------
Attachment: ZOOKEEPER-1326.patch
Attached patch switches over from 'delete' to 'rm' in a deprecating and non-breaking fashion.
Changes existing tests to use 'rm' as well.
> The CLI commands "delete" and "rmr" are confusing. Can we have "rm" + "rmr" instead?
> ------------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-1326
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1326
> Project: ZooKeeper
> Issue Type: Wish
> Components: java client
> Affects Versions: 3.4.0
> Reporter: Harsh J
> Priority: Trivial
> Attachments: ZOOKEEPER-1326.patch
>
>
> ZOOKEEPER-729 introduced 'rmr' for recursive 'delete' operations on a given node. Going by the unix convention, wouldn't it be much better if we were to have an 'rm' if there was an 'rmr' added?
> The current set is confusing. Or should we have 'delete' and 'deleteall' or summat?
> I know this is a nitpick, but I just dislike to see bad keywords used for commands.
> I'm OK to produce a backwards-compatible patch if this is acceptable.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ZOOKEEPER-1326) The CLI commands "delete" and
"rmr" are confusing. Can we have "rm" + "rmr" instead?
Posted by "Patrick Hunt (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1326?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Hunt updated ZOOKEEPER-1326:
------------------------------------
Fix Version/s: 3.5.0
> The CLI commands "delete" and "rmr" are confusing. Can we have "rm" + "rmr" instead?
> ------------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-1326
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1326
> Project: ZooKeeper
> Issue Type: Wish
> Components: java client
> Affects Versions: 3.4.0
> Reporter: Harsh J
> Assignee: Harsh J
> Priority: Trivial
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1326.patch, ZOOKEEPER-1326.patch
>
>
> ZOOKEEPER-729 introduced 'rmr' for recursive 'delete' operations on a given node. Going by the unix convention, wouldn't it be much better if we were to have an 'rm' if there was an 'rmr' added?
> The current set is confusing. Or should we have 'delete' and 'deleteall' or summat?
> I know this is a nitpick, but I just dislike to see bad keywords used for commands.
> I'm OK to produce a backwards-compatible patch if this is acceptable.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (ZOOKEEPER-1326) The CLI commands "delete" and
"rmr" are confusing. Can we have "rm" + "rmr" instead?
Posted by "Patrick Hunt (Assigned) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1326?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Hunt reassigned ZOOKEEPER-1326:
---------------------------------------
Assignee: Harsh J
> The CLI commands "delete" and "rmr" are confusing. Can we have "rm" + "rmr" instead?
> ------------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-1326
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1326
> Project: ZooKeeper
> Issue Type: Wish
> Components: java client
> Affects Versions: 3.4.0
> Reporter: Harsh J
> Assignee: Harsh J
> Priority: Trivial
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1326.patch, ZOOKEEPER-1326.patch
>
>
> ZOOKEEPER-729 introduced 'rmr' for recursive 'delete' operations on a given node. Going by the unix convention, wouldn't it be much better if we were to have an 'rm' if there was an 'rmr' added?
> The current set is confusing. Or should we have 'delete' and 'deleteall' or summat?
> I know this is a nitpick, but I just dislike to see bad keywords used for commands.
> I'm OK to produce a backwards-compatible patch if this is acceptable.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1326) The CLI commands "delete" and
"rmr" are confusing. Can we have "rm" + "rmr" instead?
Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13176099#comment-13176099 ]
Hadoop QA commented on ZOOKEEPER-1326:
--------------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12508663/ZOOKEEPER-1326.patch
against trunk revision 1222816.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/858//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/858//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/858//console
This message is automatically generated.
> The CLI commands "delete" and "rmr" are confusing. Can we have "rm" + "rmr" instead?
> ------------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-1326
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1326
> Project: ZooKeeper
> Issue Type: Wish
> Components: java client
> Affects Versions: 3.4.0
> Reporter: Harsh J
> Priority: Trivial
> Attachments: ZOOKEEPER-1326.patch, ZOOKEEPER-1326.patch
>
>
> ZOOKEEPER-729 introduced 'rmr' for recursive 'delete' operations on a given node. Going by the unix convention, wouldn't it be much better if we were to have an 'rm' if there was an 'rmr' added?
> The current set is confusing. Or should we have 'delete' and 'deleteall' or summat?
> I know this is a nitpick, but I just dislike to see bad keywords used for commands.
> I'm OK to produce a backwards-compatible patch if this is acceptable.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1326) The CLI commands "delete" and
"rmr" are confusing. Can we have "delete" + "deleteall" instead?
Posted by "Patrick Hunt (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13176470#comment-13176470 ]
Patrick Hunt commented on ZOOKEEPER-1326:
-----------------------------------------
Many more to follow I hope. ;-) thx.
> The CLI commands "delete" and "rmr" are confusing. Can we have "delete" + "deleteall" instead?
> ----------------------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-1326
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1326
> Project: ZooKeeper
> Issue Type: Wish
> Components: java client
> Affects Versions: 3.4.0
> Reporter: Harsh J
> Assignee: Harsh J
> Priority: Trivial
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1326.patch, ZOOKEEPER-1326.patch
>
>
> ZOOKEEPER-729 introduced 'rmr' for recursive 'delete' operations on a given node. Going by the unix convention, wouldn't it be much better if we were to have an 'rm' if there was an 'rmr' added?
> The current set is confusing. Or should we have 'delete' and 'deleteall' or summat?
> I know this is a nitpick, but I just dislike to see bad keywords used for commands.
> I'm OK to produce a backwards-compatible patch if this is acceptable.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ZOOKEEPER-1326) The CLI commands "delete" and
"rmr" are confusing. Can we have "delete" + "deleteall" instead?
Posted by "Harsh J (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1326?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Harsh J updated ZOOKEEPER-1326:
-------------------------------
Summary: The CLI commands "delete" and "rmr" are confusing. Can we have "delete" + "deleteall" instead? (was: The CLI commands "delete" and "rmr" are confusing. Can we have "rm" + "rmr" instead?)
Thanks Patrick and Mahadev! I believe this was my first ZK patch ever, whee :)
> The CLI commands "delete" and "rmr" are confusing. Can we have "delete" + "deleteall" instead?
> ----------------------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-1326
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1326
> Project: ZooKeeper
> Issue Type: Wish
> Components: java client
> Affects Versions: 3.4.0
> Reporter: Harsh J
> Assignee: Harsh J
> Priority: Trivial
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1326.patch, ZOOKEEPER-1326.patch
>
>
> ZOOKEEPER-729 introduced 'rmr' for recursive 'delete' operations on a given node. Going by the unix convention, wouldn't it be much better if we were to have an 'rm' if there was an 'rmr' added?
> The current set is confusing. Or should we have 'delete' and 'deleteall' or summat?
> I know this is a nitpick, but I just dislike to see bad keywords used for commands.
> I'm OK to produce a backwards-compatible patch if this is acceptable.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1326) The CLI commands "delete" and
"rmr" are confusing. Can we have "delete" + "deleteall" instead?
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13176601#comment-13176601 ]
Hudson commented on ZOOKEEPER-1326:
-----------------------------------
Integrated in ZooKeeper-trunk #1410 (See [https://builds.apache.org/job/ZooKeeper-trunk/1410/])
ZOOKEEPER-1326. The CLI commands "delete" and "rmr" are confusing. Can we have "rm" + "rmr" instead? Regenned docs. (Harsh J via phunt)
ZOOKEEPER-1326. The CLI commands "delete" and "rmr" are confusing. Can we have "rm" + "rmr" instead? (Harsh J via phunt)
phunt : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1225053
Files :
* /zookeeper/trunk/docs/bookkeeperConfig.pdf
* /zookeeper/trunk/docs/bookkeeperOverview.pdf
* /zookeeper/trunk/docs/bookkeeperProgrammer.pdf
* /zookeeper/trunk/docs/bookkeeperStarted.pdf
* /zookeeper/trunk/docs/bookkeeperStream.pdf
* /zookeeper/trunk/docs/index.pdf
* /zookeeper/trunk/docs/javaExample.pdf
* /zookeeper/trunk/docs/linkmap.pdf
* /zookeeper/trunk/docs/recipes.pdf
* /zookeeper/trunk/docs/releasenotes.pdf
* /zookeeper/trunk/docs/zookeeperAdmin.pdf
* /zookeeper/trunk/docs/zookeeperHierarchicalQuorums.pdf
* /zookeeper/trunk/docs/zookeeperInternals.pdf
* /zookeeper/trunk/docs/zookeeperJMX.pdf
* /zookeeper/trunk/docs/zookeeperObservers.pdf
* /zookeeper/trunk/docs/zookeeperOver.pdf
* /zookeeper/trunk/docs/zookeeperProgrammers.pdf
* /zookeeper/trunk/docs/zookeeperQuotas.pdf
* /zookeeper/trunk/docs/zookeeperStarted.html
* /zookeeper/trunk/docs/zookeeperStarted.pdf
* /zookeeper/trunk/docs/zookeeperTutorial.pdf
phunt : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1225052
Files :
* /zookeeper/trunk/CHANGES.txt
* /zookeeper/trunk/src/docs/src/documentation/content/xdocs/zookeeperStarted.xml
* /zookeeper/trunk/src/java/main/org/apache/zookeeper/ZooKeeperMain.java
* /zookeeper/trunk/src/java/test/org/apache/zookeeper/ZooKeeperTest.java
> The CLI commands "delete" and "rmr" are confusing. Can we have "delete" + "deleteall" instead?
> ----------------------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-1326
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1326
> Project: ZooKeeper
> Issue Type: Wish
> Components: java client
> Affects Versions: 3.4.0
> Reporter: Harsh J
> Assignee: Harsh J
> Priority: Trivial
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1326.patch, ZOOKEEPER-1326.patch
>
>
> ZOOKEEPER-729 introduced 'rmr' for recursive 'delete' operations on a given node. Going by the unix convention, wouldn't it be much better if we were to have an 'rm' if there was an 'rmr' added?
> The current set is confusing. Or should we have 'delete' and 'deleteall' or summat?
> I know this is a nitpick, but I just dislike to see bad keywords used for commands.
> I'm OK to produce a backwards-compatible patch if this is acceptable.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira