[GitHub] [superset] jinghua-qa commented on pull request #21767: feat: support mulitple temporal filters in AdhocFilter and move the Time Section away

[GitBox <gi...@apache.org>]

jinghua-qa commented on PR #21767:
URL: https://github.com/apache/superset/pull/21767#issuecomment-1298756647

   Thank you for the great work~
   I have a question, it looks like when i use custom sql in filter with time column, time comparison did not support, is this expected?
   Steps:
   1, add a time column to filter
   2, use time comparison to define start and end
   3, go to time comparison and select compare time
   
   Expect:
   time comparison will work with time filter
   
   Actual:
   time comparison did not work with time filter
   
   https://user-images.githubusercontent.com/81597121/199279123-f07f150d-7db2-4149-ae2d-1e87f9253451.mov
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org