[GitHub] [jena] kinow commented on a change in pull request #729: JENA-1884: remove JenaUUID

[GitBox <gi...@apache.org>]

kinow commented on a change in pull request #729: JENA-1884: remove JenaUUID
URL: https://github.com/apache/jena/pull/729#discussion_r410769237
 
 

 ##########
 File path: jena-base/src/main/java/org/apache/jena/atlas/lib/BitsInt.java
 ##########
 @@ -155,14 +155,27 @@ boolean test(int bits, int value, int start, int finish)
      *  @param finish
      *  @return int
      */
-    
+
     public static final
     int access(int bits, int start, int finish)
     {
         check(start, finish) ;
-        return access$(bits, start, finish) ; 
+        return access$(bits, start, finish) ;
+    }
+
+    /**
+     * Clear the bit specified.
+     *  @param bits
+     *  @param bitIndex
+     *  @return int
+     */
+    public static final
+    int clear(int bits, int bitIndex)
+    {
+        check(bitIndex);
+        return clear$(bits, bitIndex) ;
 
 Review comment:
   `clear$` already does the `check(bitIndex)`. Would it be better to have it only there, or is it better to be safe and perform that verification on both methods?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org