You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "huibertalblas (via GitHub)" <gi...@apache.org> on 2023/08/08 09:16:59 UTC

[GitHub] [pulsar] huibertalblas opened a new pull request, #20953: [improve][pip] PIP-292: Enforce token expiration time in the Websockets plugin

huibertalblas opened a new pull request, #20953:
URL: https://github.com/apache/pulsar/pull/20953

   ### Does this pull request potentially affect one of the following parts:
   
   <!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
   
   *If the box was checked, please highlight the changes*
   
   - [ ] Dependencies (add or upgrade a dependency)
   - [ ] The public API
   - [ ] The schema
   - [ ] The default values of configurations
   - [ ] The threading model
   - [ ] The binary protocol
   - [ ] The REST endpoints
   - [ ] The admin CLI options
   - [ ] The metrics
   - [ ] Anything that affects deployment
   
   ### Documentation
   
   <!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
   
   - [ ] `doc` <!-- Your PR contains doc changes. -->
   - [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
   - [x] `doc-not-needed` <!-- Your PR changes do not impact docs -->
   - [ ] `doc-complete` <!-- Docs have been already added -->
   
   ### Matching PR in forked repository
   
   PR in forked repository: x


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [improve][pip] PIP-292: Enforce token expiration time in the Websockets plugin [pulsar]

Posted by "lhotari (via GitHub)" <gi...@apache.org>.
lhotari merged PR #20953:
URL: https://github.com/apache/pulsar/pull/20953


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar] github-actions[bot] commented on pull request #20953: [improve][pip] PIP-292: Enforce token expiration time in the Websockets plugin

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #20953:
URL: https://github.com/apache/pulsar/pull/20953#issuecomment-1710965274

   The pr had no activity for 30 days, mark with Stale label.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [improve][pip] PIP-292: Enforce token expiration time in the Websockets plugin [pulsar]

Posted by "lhotari (via GitHub)" <gi...@apache.org>.
lhotari commented on code in PR #20953:
URL: https://github.com/apache/pulsar/pull/20953#discussion_r2003661490


##########
pip/pip-292.md:
##########
@@ -0,0 +1,99 @@
+# Background knowledge

Review Comment:
   Please add the title in the PIP document. There has been some bad examples in the past where the title has been missing from the PIP document itself.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [improve][pip] PIP-292: Enforce token expiration time in the Websockets plugin [pulsar]

Posted by "huibertalblas (via GitHub)" <gi...@apache.org>.
huibertalblas commented on PR #20953:
URL: https://github.com/apache/pulsar/pull/20953#issuecomment-2488187269

   @lhotari  Do you want to merge this PR?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [improve][pip] PIP-292: Enforce token expiration time in the Websockets plugin [pulsar]

Posted by "lhotari (via GitHub)" <gi...@apache.org>.
lhotari commented on code in PR #20953:
URL: https://github.com/apache/pulsar/pull/20953#discussion_r2003671717


##########
pip/pip-292.md:
##########
@@ -0,0 +1,99 @@
+# Background knowledge

Review Comment:
   I handled this detail.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [improve][pip] PIP-292: Enforce token expiration time in the Websockets plugin [pulsar]

Posted by "huibertalblas (via GitHub)" <gi...@apache.org>.
huibertalblas commented on PR #20953:
URL: https://github.com/apache/pulsar/pull/20953#issuecomment-2363311790

   @nicoloboschi Would you want to merge this PR?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org