You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by "Phabricator (Updated) (JIRA)" <ji...@apache.org> on 2012/03/15 19:05:39 UTC
[jira] [Updated] (HIVE-2871) Add a new hook to run at the beginning
and end of the Driver.run method
[ https://issues.apache.org/jira/browse/HIVE-2871?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Phabricator updated HIVE-2871:
------------------------------
Attachment: HIVE-2871.D2331.1.patch
kevinwilfong requested code review of "HIVE-2871 [jira] Add a new hook to run at the beginning and end of the Driver.run method".
Reviewers: JIRA
https://issues.apache.org/jira/browse/HIVE-2871
Added a new hook which runs at the beginning and end of the Driver.run method. It has pre and post execution methods. I do not provide any implementations as part of this diff.
Driver.run is the highest level method which all queries go through, whether they come from Hive Server, the CLI, or any other entry. We also do not have any hooks before the compilation method is called, and having hooks in Driver.run would provide this. Having hooks in Driver.run will allow, for example, being able to overwrite config values used throughout query processing, including compilation, and at the other end, cleaning up any resources/logging any final values just before returning to the user.
TEST PLAN
EMPTY
REVISION DETAIL
https://reviews.facebook.net/D2331
AFFECTED FILES
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java
ql/src/test/results/clientpositive/hook_order.q.out
ql/src/test/org/apache/hadoop/hive/ql/hooks/VerifyHooksRunInOrder.java
ql/src/test/queries/clientpositive/hook_order.q
ql/src/java/org/apache/hadoop/hive/ql/HiveDriverRunHook.java
ql/src/java/org/apache/hadoop/hive/ql/HiveDriverRunHookContextImpl.java
ql/src/java/org/apache/hadoop/hive/ql/HiveDriverRunHookContext.java
ql/src/java/org/apache/hadoop/hive/ql/Driver.java
MANAGE HERALD DIFFERENTIAL RULES
https://reviews.facebook.net/herald/view/differential/
WHY DID I GET THIS EMAIL?
https://reviews.facebook.net/herald/transcript/5163/
Tip: use the X-Herald-Rules header to filter Herald messages in your client.
> Add a new hook to run at the beginning and end of the Driver.run method
> -----------------------------------------------------------------------
>
> Key: HIVE-2871
> URL: https://issues.apache.org/jira/browse/HIVE-2871
> Project: Hive
> Issue Type: Improvement
> Reporter: Kevin Wilfong
> Assignee: Kevin Wilfong
> Attachments: HIVE-2871.D2331.1.patch
>
>
> Driver.run is the highest level method which all queries go through, whether they come from Hive Server, the CLI, or any other entry. We also do not have any hooks before the compilation method is called, and having hooks in Driver.run would provide this. Having hooks in Driver.run will allow, for example, being able to overwrite config values used throughout query processing, including compilation, and at the other end, cleaning up any resources/logging any final values just before returning to the user.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira