You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/12/15 08:19:17 UTC

[GitHub] [spark] HyukjinKwon commented on a change in pull request #26884: [SPARK-30257] [PySpark] Add simpleString map

HyukjinKwon commented on a change in pull request #26884: [SPARK-30257] [PySpark] Add simpleString map
URL: https://github.com/apache/spark/pull/26884#discussion_r357961329
 
 

 ##########
 File path: python/pyspark/sql/types.py
 ##########
 @@ -1603,6 +1627,13 @@ def convert(self, obj, gateway_client):
         t.setNanos(obj.microsecond * 1000)
         return t
 
+
+def from_simple_string(simple_str):
 
 Review comment:
   Is it an API? I don't think this is a particularily useful. I wouldn't add it.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org