You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/08/22 12:38:16 UTC

[GitHub] [pulsar] jianyun8023 commented on a change in pull request #7863: support message dispatch rate on topic level

jianyun8023 commented on a change in pull request #7863:
URL: https://github.com/apache/pulsar/pull/7863#discussion_r475082742



##########
File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/PersistentTopicsBase.java
##########
@@ -3056,4 +3057,53 @@ protected void internalGetLastMessageId(AsyncResponse asyncResponse, boolean aut
         });
 
     }
+
+    protected void internalGetDispatchRate(AsyncResponse asyncResponse) {

Review comment:
       It is recommended to return CompletableFuture instead of passing in the parameter AsyncResponse




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org