[GitHub] [arrow] save-buffer commented on a diff in pull request #15253: GH-32653: [C++] Cleanup error handling in execution engine

["save-buffer (via GitHub)" <gi...@apache.org>]

save-buffer commented on code in PR #15253:
URL: https://github.com/apache/arrow/pull/15253#discussion_r1084711012


##########
cpp/src/arrow/compute/exec/exec_plan.h:
##########
@@ -121,18 +119,20 @@ class ARROW_EXPORT ExecNode {
 
   virtual const char* kind_name() const = 0;
 
-  // The number of inputs/outputs expected by this node
+  // The number of inputs expected by this node
   int num_inputs() const { return static_cast<int>(inputs_.size()); }
-  int num_outputs() const { return num_outputs_; }
 
   /// This node's predecessors in the exec plan
   const NodeVector& inputs() const { return inputs_; }
 
+  /// True if the plan has no output schema (is a sink)
+  bool is_sink() const { return !output_schema_; }

Review Comment:
   I guess it's a pretty semantic thing, but I feel like a sink node has an output schema, just not a node that it outputs to (since a sink node does output to an AsyncGenerator). Maybe it doesn't matter too much though 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org