You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/04/29 15:50:00 UTC
[GitHub] [incubator-doris] morningman opened a new pull request, #9329: [fix](alter-job) Missing alter job when doing checkpoint image
morningman opened a new pull request, #9329:
URL: https://github.com/apache/incubator-doris/pull/9329
# Proposed changes
Issue Number: close #xxx
## Problem Summary:
This bug is introduced from #8030
## Checklist(Required)
1. Does it affect the original behavior: (No)
2. Has unit tests been added: (Nod)
3. Has document been added or modified: (No Need)
4. Does it need to update dependencies: (No)
5. Are there any changes that cannot be rolled back: (No)
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] github-actions[bot] commented on pull request #9329: [fix](alter-job) Missing alter job when doing checkpoint image
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #9329:
URL: https://github.com/apache/incubator-doris/pull/9329#issuecomment-1114200886
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman commented on a diff in pull request #9329: [fix](alter-job) Missing alter job when doing checkpoint image
Posted by GitBox <gi...@apache.org>.
morningman commented on code in PR #9329:
URL: https://github.com/apache/incubator-doris/pull/9329#discussion_r862454556
##########
fe/fe-core/src/main/java/org/apache/doris/catalog/Catalog.java:
##########
@@ -2113,6 +2109,13 @@ public long saveAlterJob(CountingDataOutputStream dos, long checksum) throws IOE
public long saveAlterJob(CountingDataOutputStream dos, long checksum, JobType type) throws IOException {
Map<Long, AlterJobV2> alterJobsV2 = Maps.newHashMap();
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] github-actions[bot] commented on pull request #9329: [fix](alter-job) Missing alter job when doing checkpoint image
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #9329:
URL: https://github.com/apache/incubator-doris/pull/9329#issuecomment-1114200887
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] xy720 commented on a diff in pull request #9329: [fix](alter-job) Missing alter job when doing checkpoint image
Posted by GitBox <gi...@apache.org>.
xy720 commented on code in PR #9329:
URL: https://github.com/apache/incubator-doris/pull/9329#discussion_r862349405
##########
fe/fe-core/src/main/java/org/apache/doris/catalog/Catalog.java:
##########
@@ -2113,6 +2109,13 @@ public long saveAlterJob(CountingDataOutputStream dos, long checksum) throws IOE
public long saveAlterJob(CountingDataOutputStream dos, long checksum, JobType type) throws IOException {
Map<Long, AlterJobV2> alterJobsV2 = Maps.newHashMap();
Review Comment:
```suggestion
Map<Long, AlterJobV2> alterJobsV2;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman merged pull request #9329: [fix](alter-job) Missing alter job when doing checkpoint image
Posted by GitBox <gi...@apache.org>.
morningman merged PR #9329:
URL: https://github.com/apache/incubator-doris/pull/9329
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org