You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@celeborn.apache.org by GitBox <gi...@apache.org> on 2022/12/12 03:20:30 UTC
[GitHub] [incubator-celeborn] zhongqiangczq opened a new pull request, #1062: [CELEBORN-120] MapPartitionFileWriter completes some functions to sup…
zhongqiangczq opened a new pull request, #1062:
URL: https://github.com/apache/incubator-celeborn/pull/1062
…port mappartition
# [BUG]/[FEATURE] title
### What changes were proposed in this pull request?
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
### What are the items that need reviewer attention?
### Related issues.
### Related pull requests.
### How was this patch tested?
/cc @related-reviewer
@waitinfuture @RexXiong @FMX
/assign @main-reviewer
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] pan3793 commented on pull request #1062: [CELEBORN-120] MapPartitionFileWriter completes some functions to sup…
Posted by GitBox <gi...@apache.org>.
pan3793 commented on PR #1062:
URL: https://github.com/apache/incubator-celeborn/pull/1062#issuecomment-1356839791
@waitinfuture if we find a commit introduced issue, generally we should discuss on the original PR and evaluate if there is an opportunity to fix it by sending a followup PR before reverting, if we decide to revert it eventually, please leave comments on the original PR to clarify why should we do that, to avoid confusing the future explorers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] waitinfuture commented on pull request #1062: [CELEBORN-120] MapPartitionFileWriter completes some functions to sup…
Posted by GitBox <gi...@apache.org>.
waitinfuture commented on PR #1062:
URL: https://github.com/apache/incubator-celeborn/pull/1062#issuecomment-1357090107
>
Thanks for pointing out, we discussed offline but I forgot to discuss here.
The reason to revert this pr is that this pr causes the main branch compiles error, to avoid blocking other prs I decided to revert. Looking back, it maybe better to fix by sending a followup PR instead of reverting. I will be more careful about reverting, thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] waitinfuture merged pull request #1062: [CELEBORN-120] MapPartitionFileWriter completes some functions to sup…
Posted by GitBox <gi...@apache.org>.
waitinfuture merged PR #1062:
URL: https://github.com/apache/incubator-celeborn/pull/1062
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] codecov[bot] commented on pull request #1062: [CELEBORN-120] MapPartitionFileWriter completes some functions to sup…
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #1062:
URL: https://github.com/apache/incubator-celeborn/pull/1062#issuecomment-1345821658
# [Codecov](https://codecov.io/gh/apache/incubator-celeborn/pull/1062?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1062](https://codecov.io/gh/apache/incubator-celeborn/pull/1062?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (89d23a9) into [main](https://codecov.io/gh/apache/incubator-celeborn/commit/84d67d019dff73580bd14aa489ce939e2f1fc58c?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (84d67d0) will **decrease** coverage by `0.12%`.
> The diff coverage is `0.00%`.
```diff
@@ Coverage Diff @@
## main #1062 +/- ##
============================================
- Coverage 25.26% 25.14% -0.13%
- Complexity 772 776 +4
============================================
Files 212 212
Lines 18027 18141 +114
Branches 2036 2053 +17
============================================
+ Hits 4555 4561 +6
- Misses 13162 13274 +112
+ Partials 310 306 -4
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-celeborn/pull/1062?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../deploy/worker/storage/MapPartitionFileWriter.java](https://codecov.io/gh/apache/incubator-celeborn/pull/1062/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d29ya2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9jZWxlYm9ybi9zZXJ2aWNlL2RlcGxveS93b3JrZXIvc3RvcmFnZS9NYXBQYXJ0aXRpb25GaWxlV3JpdGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...celeborn/service/deploy/master/SlotsAllocator.java](https://codecov.io/gh/apache/incubator-celeborn/pull/1062/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bWFzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9jZWxlYm9ybi9zZXJ2aWNlL2RlcGxveS9tYXN0ZXIvU2xvdHNBbGxvY2F0b3IuamF2YQ==) | `71.72% <0.00%> (+2.45%)` | :arrow_up: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org