[GitHub] [superset] justinpark commented on a diff in pull request #24205: feat(sqllab): SQLEditor Extension

["justinpark (via GitHub)" <gi...@apache.org>]

justinpark commented on code in PR #24205:
URL: https://github.com/apache/superset/pull/24205#discussion_r1218469196


##########
superset-frontend/src/SqlLab/components/SqlEditor/index.jsx:
##########
@@ -673,6 +684,15 @@ const SqlEditor = ({
         onDragEnd={onResizeEnd}
       >
         <div ref={northPaneRef} className="north-pane">
+          {SqlFormExtension && (
+            <SqlFormExtension
+              queryEditorId={queryEditor.id}
+              setQueryEditorAndSaveSqlWithDebounce={

Review Comment:
   @geido @Antonio-RiveroMartnez similar to [the previous comment](https://github.com/apache/superset/pull/24205#discussion_r1205807291), this action props doesn't make sense since your custom component only needs these actions. You can hook up these actions in your custom component by combining of existing action helpers
   
   For example you can build startQuery in your component by combining of runQueryFromSqlEditor and setActiveSouthPaneTab
   ```
         dispatch(
           runQueryFromSqlEditor(
             database,
             queryEditor,
             defaultQueryLimit,
             ctasArg ? ctas : '',
             ctasArg,
             ctas_method,
           ),
         );
         dispatch(setActiveSouthPaneTab('Results'));
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org