You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brpc.apache.org by GitBox <gi...@apache.org> on 2020/06/02 10:17:53 UTC
[GitHub] [incubator-brpc] liumh8 opened a new issue #1131: ParseRedisMessage 非法内存引用？
liumh8 opened a new issue #1131:
URL: https://github.com/apache/incubator-brpc/issues/1131
如果这里[parser](https://github.com/apache/incubator-brpc/blob/4e519089a4f009c6892409a1a70d76fdb07eb5d5/src/brpc/policy/redis_protocol.cpp#L172)返回`PARSE_ERROR_NOT_ENOUGH_DATA`，说明只解析了一部分，但是[arena](https://github.com/apache/incubator-brpc/blob/4e519089a4f009c6892409a1a70d76fdb07eb5d5/src/brpc/policy/redis_protocol.cpp#L192)会把之前已解析参数申请的内存释放掉，那么等这个命令完全解析后，使用时就引用了非法内存地址。
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org
[GitHub] [incubator-brpc] liumh8 closed issue #1131: ParseRedisMessage 非法内存引用？
Posted by GitBox <gi...@apache.org>.
liumh8 closed issue #1131:
URL: https://github.com/apache/incubator-brpc/issues/1131
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org
[GitHub] [incubator-brpc] gydong commented on issue #1131: ParseRedisMessage 非法内存引用？
Posted by GitBox <gi...@apache.org>.
gydong commented on issue #1131:
URL: https://github.com/apache/incubator-brpc/issues/1131#issuecomment-700582780
已经修复了，见：https://github.com/apache/incubator-brpc/pull/1156
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org
[GitHub] [incubator-brpc] luluyouyue commented on issue #1131: ParseRedisMessage 非法内存引用？
Posted by GitBox <gi...@apache.org>.
luluyouyue commented on issue #1131:
URL: https://github.com/apache/incubator-brpc/issues/1131#issuecomment-700574013
请问这个问题已经修复了吗
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org
[GitHub] [incubator-brpc] zyearn commented on issue #1131: ParseRedisMessage 非法内存引用？
Posted by GitBox <gi...@apache.org>.
zyearn commented on issue #1131:
URL: https://github.com/apache/incubator-brpc/issues/1131#issuecomment-637608392
是的，我看到你在新的commit修复了，我看一下。另外pr还剩两个review意见也修改提交一下吧。
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org
[GitHub] [incubator-brpc] liumh8 commented on issue #1131: ParseRedisMessage 非法内存引用？
Posted by GitBox <gi...@apache.org>.
liumh8 commented on issue #1131:
URL: https://github.com/apache/incubator-brpc/issues/1131#issuecomment-637442681
如果parser返回PARSE_OK，才arena.clear()
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org
[GitHub] [incubator-brpc] liumh8 commented on issue #1131: ParseRedisMessage 非法内存引用？
Posted by GitBox <gi...@apache.org>.
liumh8 commented on issue #1131:
URL: https://github.com/apache/incubator-brpc/issues/1131#issuecomment-637443126
@zyearn 你好，请确认一下是否如上所述？
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org
[GitHub] [incubator-brpc] liumh8 commented on issue #1131: ParseRedisMessage 非法内存引用？
Posted by GitBox <gi...@apache.org>.
liumh8 commented on issue #1131:
URL: https://github.com/apache/incubator-brpc/issues/1131#issuecomment-745037525
> 已经修复了，见：#1156
没有修复吧，1156是修复的另一个[bug](https://github.com/apache/incubator-brpc/issues/1155)吧
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org