You are viewing a plain text version of this content. The canonical link for it is here.
Posted to derby-dev@db.apache.org by "Dyre Tjeldvoll (JIRA)" <ji...@apache.org> on 2008/04/06 17:15:24 UTC
[jira] Created: (DERBY-3598) Modify ReleaseNoteGenerator and
ChangesGenerator to exclude issues that are fixed in earlier releases
Modify ReleaseNoteGenerator and ChangesGenerator to exclude issues that are fixed in earlier releases
-----------------------------------------------------------------------------------------------------
Key: DERBY-3598
URL: https://issues.apache.org/jira/browse/DERBY-3598
Project: Derby
Issue Type: Improvement
Components: Build tools
Affects Versions: 10.4.1.0
Reporter: Dyre Tjeldvoll
Assignee: Dyre Tjeldvoll
Priority: Minor
Fix For: 10.5.0.0
Since we cannot create a Jira filter which selects issues with a set fix versions and at the same time EXCLUDE issues with another set of fix versions, it would be nice if the *Generator programs could filter out those issues already fixed in previously released versions.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-3598) Modify ReleaseNoteGenerator and
ChangesGenerator to exclude issues that are fixed in earlier releases
Posted by "Myrna van Lunteren (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3598?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Myrna van Lunteren updated DERBY-3598:
--------------------------------------
Attachment: DERBY-3598.v3.diff
I've tried to consolidate the v2.diff patch with the changes made with revision 683346, but so far it's doing the same thing with, or without my changes.
I debugged this as far as finding that the excludeVersion item gets read, but the fixversions aren't available when the comparison is done (in JiraIssue.createJiraIssueList()).
I'd appreciate a hint if anyone has the time/inclination to look at this attempt.
I did try out Dyre's original v2.diff patch, but that one no longer picks up any bugs at all - presumably this is why the changes of revision 683346 were made.
> Modify ReleaseNoteGenerator and ChangesGenerator to exclude issues that are fixed in earlier releases
> -----------------------------------------------------------------------------------------------------
>
> Key: DERBY-3598
> URL: https://issues.apache.org/jira/browse/DERBY-3598
> Project: Derby
> Issue Type: Improvement
> Components: Build tools
> Affects Versions: 10.4.1.3
> Reporter: Dyre Tjeldvoll
> Priority: Minor
> Attachments: derby-3598.diff, derby-3598.v2.diff, derby-3598.v2.stat, DERBY-3598.v3.diff
>
>
> Since we cannot create a Jira filter which selects issues with a set fix versions and at the same time EXCLUDE issues with another set of fix versions, it would be nice if the *Generator programs could filter out those issues already fixed in previously released versions.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-3598) Modify ReleaseNoteGenerator and
ChangesGenerator to exclude issues that are fixed in earlier releases
Posted by "Rick Hillegas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12586371#action_12586371 ]
Rick Hillegas commented on DERBY-3598:
--------------------------------------
Hi Dyre,
I think that this patch will do what you want. However, I would be tempted to solve this problem a different way. Instead. of specifying the excluded versions on the command line, I would give releaseSummary.xml a new element for the excluded version list. That element can have a variable number of version sub-elements. The purpose of releaseSummary.xml is to hold a number of inputs which would otherwise make the command line unwieldy.
> Modify ReleaseNoteGenerator and ChangesGenerator to exclude issues that are fixed in earlier releases
> -----------------------------------------------------------------------------------------------------
>
> Key: DERBY-3598
> URL: https://issues.apache.org/jira/browse/DERBY-3598
> Project: Derby
> Issue Type: Improvement
> Components: Build tools
> Affects Versions: 10.4.1.0
> Reporter: Dyre Tjeldvoll
> Assignee: Dyre Tjeldvoll
> Priority: Minor
> Fix For: 10.5.0.0
>
> Attachments: derby-3598.diff
>
>
> Since we cannot create a Jira filter which selects issues with a set fix versions and at the same time EXCLUDE issues with another set of fix versions, it would be nice if the *Generator programs could filter out those issues already fixed in previously released versions.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (DERBY-3598) Modify ReleaseNoteGenerator and
ChangesGenerator to exclude issues that are fixed in earlier releases
Posted by "Myrna van Lunteren (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3598?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Myrna van Lunteren resolved DERBY-3598.
---------------------------------------
Resolution: Fixed
Fix Version/s: 10.6.0.0
10.5.1.2
Derby Info: (was: [Patch Available])
I merged revision 782867 to 10.5 with modifications because of the removal of the changes file during the 10.5.1.1 release work.
I'm resolving this issue, I'm sure more tweaking can/will be done for 10.5.2.
> Modify ReleaseNoteGenerator and ChangesGenerator to exclude issues that are fixed in earlier releases
> -----------------------------------------------------------------------------------------------------
>
> Key: DERBY-3598
> URL: https://issues.apache.org/jira/browse/DERBY-3598
> Project: Derby
> Issue Type: Improvement
> Components: Build tools
> Affects Versions: 10.4.1.3
> Reporter: Dyre Tjeldvoll
> Assignee: Myrna van Lunteren
> Priority: Minor
> Fix For: 10.5.1.2, 10.6.0.0
>
> Attachments: derby-3598.diff, derby-3598.v2.diff, derby-3598.v2.stat, DERBY-3598.v3.diff, DERBY-3598.v4.diff, RELEASE-NOTES.html
>
>
> Since we cannot create a Jira filter which selects issues with a set fix versions and at the same time EXCLUDE issues with another set of fix versions, it would be nice if the *Generator programs could filter out those issues already fixed in previously released versions.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-3598) Modify ReleaseNoteGenerator and
ChangesGenerator to exclude issues that are fixed in earlier releases
Posted by "Myrna van Lunteren (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3598?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Myrna van Lunteren updated DERBY-3598:
--------------------------------------
Attachment: RELEASE-NOTES.html
DERBY-3598.v4.diff
Attaching a patch in which I went back to dyre's patch - undoing Rick's changes - except for one small adjustment in JiraIssue, where I added a little boolean skip check (before, issues got added whether they were fixed in previous releases or not).
Also attaching a sample RELEASE-NOTES.html which I obtained by copying the changed files to my 10.5 environment, running the same filters I used for 10.5.1.1 and saving the .xml files, then running ant genrelnotes in the tools/release directory.
Note that this did indeed skip some issues that had been fixed in earlier releases.
Note also, that the JiraConnector class will get similar .xml files as saving the filter results, except that that includes other types of issues (duplicates, for instance).
I'd like to commit these changes, unless someone thinks we should harrangue infrastructure about the lack of 'XML' (again, it seems we only get 'rss') in JIRA. In that case I'll have to pass on doing further work on this.
> Modify ReleaseNoteGenerator and ChangesGenerator to exclude issues that are fixed in earlier releases
> -----------------------------------------------------------------------------------------------------
>
> Key: DERBY-3598
> URL: https://issues.apache.org/jira/browse/DERBY-3598
> Project: Derby
> Issue Type: Improvement
> Components: Build tools
> Affects Versions: 10.4.1.3
> Reporter: Dyre Tjeldvoll
> Priority: Minor
> Attachments: derby-3598.diff, derby-3598.v2.diff, derby-3598.v2.stat, DERBY-3598.v3.diff, DERBY-3598.v4.diff, RELEASE-NOTES.html
>
>
> Since we cannot create a Jira filter which selects issues with a set fix versions and at the same time EXCLUDE issues with another set of fix versions, it would be nice if the *Generator programs could filter out those issues already fixed in previously released versions.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-3598) Modify ReleaseNoteGenerator and
ChangesGenerator to exclude issues that are fixed in earlier releases
Posted by "Myrna van Lunteren (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3598?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Myrna van Lunteren updated DERBY-3598:
--------------------------------------
Derby Info: [Patch Available]
> Modify ReleaseNoteGenerator and ChangesGenerator to exclude issues that are fixed in earlier releases
> -----------------------------------------------------------------------------------------------------
>
> Key: DERBY-3598
> URL: https://issues.apache.org/jira/browse/DERBY-3598
> Project: Derby
> Issue Type: Improvement
> Components: Build tools
> Affects Versions: 10.4.1.3
> Reporter: Dyre Tjeldvoll
> Priority: Minor
> Attachments: derby-3598.diff, derby-3598.v2.diff, derby-3598.v2.stat, DERBY-3598.v3.diff, DERBY-3598.v4.diff, RELEASE-NOTES.html
>
>
> Since we cannot create a Jira filter which selects issues with a set fix versions and at the same time EXCLUDE issues with another set of fix versions, it would be nice if the *Generator programs could filter out those issues already fixed in previously released versions.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-3598) Modify ReleaseNoteGenerator and
ChangesGenerator to exclude issues that are fixed in earlier releases
Posted by "Myrna van Lunteren (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3598?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Myrna van Lunteren updated DERBY-3598:
--------------------------------------
Fix Version/s: (was: 10.5.0.0)
Removing 10.5 from fix in. I've looked into merging the patch with the current state of the source, specifically ReleaseNotesGenerator.java, but some changes - notably revision 683346 for DERBY-3820 - which make the patch invalid. I'm giving up on it for the first 10.5 release candidate.
> Modify ReleaseNoteGenerator and ChangesGenerator to exclude issues that are fixed in earlier releases
> -----------------------------------------------------------------------------------------------------
>
> Key: DERBY-3598
> URL: https://issues.apache.org/jira/browse/DERBY-3598
> Project: Derby
> Issue Type: Improvement
> Components: Build tools
> Affects Versions: 10.4.1.3
> Reporter: Dyre Tjeldvoll
> Priority: Minor
> Attachments: derby-3598.diff, derby-3598.v2.diff, derby-3598.v2.stat
>
>
> Since we cannot create a Jira filter which selects issues with a set fix versions and at the same time EXCLUDE issues with another set of fix versions, it would be nice if the *Generator programs could filter out those issues already fixed in previously released versions.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-3598) Modify ReleaseNoteGenerator and
ChangesGenerator to exclude issues that are fixed in earlier releases
Posted by "Myrna van Lunteren (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12717528#action_12717528 ]
Myrna van Lunteren commented on DERBY-3598:
-------------------------------------------
I committed patch v4.diff to trunk with revision 782867.
> Modify ReleaseNoteGenerator and ChangesGenerator to exclude issues that are fixed in earlier releases
> -----------------------------------------------------------------------------------------------------
>
> Key: DERBY-3598
> URL: https://issues.apache.org/jira/browse/DERBY-3598
> Project: Derby
> Issue Type: Improvement
> Components: Build tools
> Affects Versions: 10.4.1.3
> Reporter: Dyre Tjeldvoll
> Priority: Minor
> Attachments: derby-3598.diff, derby-3598.v2.diff, derby-3598.v2.stat, DERBY-3598.v3.diff, DERBY-3598.v4.diff, RELEASE-NOTES.html
>
>
> Since we cannot create a Jira filter which selects issues with a set fix versions and at the same time EXCLUDE issues with another set of fix versions, it would be nice if the *Generator programs could filter out those issues already fixed in previously released versions.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (DERBY-3598) Modify ReleaseNoteGenerator and
ChangesGenerator to exclude issues that are fixed in earlier releases
Posted by "Myrna van Lunteren (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3598?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Myrna van Lunteren reassigned DERBY-3598:
-----------------------------------------
Assignee: Myrna van Lunteren
> Modify ReleaseNoteGenerator and ChangesGenerator to exclude issues that are fixed in earlier releases
> -----------------------------------------------------------------------------------------------------
>
> Key: DERBY-3598
> URL: https://issues.apache.org/jira/browse/DERBY-3598
> Project: Derby
> Issue Type: Improvement
> Components: Build tools
> Affects Versions: 10.4.1.3
> Reporter: Dyre Tjeldvoll
> Assignee: Myrna van Lunteren
> Priority: Minor
> Attachments: derby-3598.diff, derby-3598.v2.diff, derby-3598.v2.stat, DERBY-3598.v3.diff, DERBY-3598.v4.diff, RELEASE-NOTES.html
>
>
> Since we cannot create a Jira filter which selects issues with a set fix versions and at the same time EXCLUDE issues with another set of fix versions, it would be nice if the *Generator programs could filter out those issues already fixed in previously released versions.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (DERBY-3598) Modify ReleaseNoteGenerator and
ChangesGenerator to exclude issues that are fixed in earlier releases
Posted by "Dyre Tjeldvoll (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3598?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dyre Tjeldvoll reassigned DERBY-3598:
-------------------------------------
Assignee: (was: Dyre Tjeldvoll)
I'm unassigning myself from this issue, as don't plan to do more work on it. Personally I think the latest patch warrants inclusion but I won't be pursuing that myself. Future release managers may want to take a look.
> Modify ReleaseNoteGenerator and ChangesGenerator to exclude issues that are fixed in earlier releases
> -----------------------------------------------------------------------------------------------------
>
> Key: DERBY-3598
> URL: https://issues.apache.org/jira/browse/DERBY-3598
> Project: Derby
> Issue Type: Improvement
> Components: Build tools
> Affects Versions: 10.4.1.3
> Reporter: Dyre Tjeldvoll
> Priority: Minor
> Fix For: 10.5.0.0
>
> Attachments: derby-3598.diff, derby-3598.v2.diff, derby-3598.v2.stat
>
>
> Since we cannot create a Jira filter which selects issues with a set fix versions and at the same time EXCLUDE issues with another set of fix versions, it would be nice if the *Generator programs could filter out those issues already fixed in previously released versions.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-3598) Modify ReleaseNoteGenerator and
ChangesGenerator to exclude issues that are fixed in earlier releases
Posted by "Dyre Tjeldvoll (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3598?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dyre Tjeldvoll updated DERBY-3598:
----------------------------------
Attachment: derby-3598.v2.stat
derby-3598.v2.diff
I've attached a new patch (v2) which implements Rick's suggestion. The patch is rather large because I included some additional changes:
1. Read the current version number from main.properties, so that doesn't have to be specified in releaseSummary.xml
2. Added excludeVersion as a tag in releaseSummary.xml (there can be any number of such tags with different values)
3. Refactored identical code from ReleaseNoteGenerator and ChangesGenerator into a common base class
4. Factored out the duplicated nested class JiraIssue to an ordinary class
5. Removed the nested class GeneratorState
6. Renamed "pamphletFile" to "outputFile" which I found more intuitive (possibly because English is not my native language)
> Modify ReleaseNoteGenerator and ChangesGenerator to exclude issues that are fixed in earlier releases
> -----------------------------------------------------------------------------------------------------
>
> Key: DERBY-3598
> URL: https://issues.apache.org/jira/browse/DERBY-3598
> Project: Derby
> Issue Type: Improvement
> Components: Build tools
> Affects Versions: 10.4.1.3
> Reporter: Dyre Tjeldvoll
> Assignee: Dyre Tjeldvoll
> Priority: Minor
> Fix For: 10.5.0.0
>
> Attachments: derby-3598.diff, derby-3598.v2.diff, derby-3598.v2.stat
>
>
> Since we cannot create a Jira filter which selects issues with a set fix versions and at the same time EXCLUDE issues with another set of fix versions, it would be nice if the *Generator programs could filter out those issues already fixed in previously released versions.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-3598) Modify ReleaseNoteGenerator and
ChangesGenerator to exclude issues that are fixed in earlier releases
Posted by "Myrna van Lunteren (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12713763#action_12713763 ]
Myrna van Lunteren commented on DERBY-3598:
-------------------------------------------
How do we get an XML file?
After some more looking, I figure that in fact, my report - which was the same xml file I used to generate the 10.5.1.1 release notes - indeed did not have FixVersion tags at all.
We'd need to go out to JIRA and get an xml for an individual bug, or, add the fixVersion to the list of fields included in the printout of the JIRA report.
However, when I tried to get an XML out of JIRA, I got RSS instead.
I am almost certain that for 10.5.1.1 I just used firefox, brought up the filter, clicked on XML, then saved that as xhtml. But now, when I do that, I get RSS output rather than XML.
Is something wrong with JIRA?
> Modify ReleaseNoteGenerator and ChangesGenerator to exclude issues that are fixed in earlier releases
> -----------------------------------------------------------------------------------------------------
>
> Key: DERBY-3598
> URL: https://issues.apache.org/jira/browse/DERBY-3598
> Project: Derby
> Issue Type: Improvement
> Components: Build tools
> Affects Versions: 10.4.1.3
> Reporter: Dyre Tjeldvoll
> Priority: Minor
> Attachments: derby-3598.diff, derby-3598.v2.diff, derby-3598.v2.stat, DERBY-3598.v3.diff
>
>
> Since we cannot create a Jira filter which selects issues with a set fix versions and at the same time EXCLUDE issues with another set of fix versions, it would be nice if the *Generator programs could filter out those issues already fixed in previously released versions.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-3598) Modify ReleaseNoteGenerator and
ChangesGenerator to exclude issues that are fixed in earlier releases
Posted by "Rick Hillegas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12713576#action_12713576 ]
Rick Hillegas commented on DERBY-3598:
--------------------------------------
Hi Myrna,
It sounds like the logic at the end of the constructor for JiraIssue may not be properly parsing the list of fixed versions in the new xml format for JIRA issues.
> Modify ReleaseNoteGenerator and ChangesGenerator to exclude issues that are fixed in earlier releases
> -----------------------------------------------------------------------------------------------------
>
> Key: DERBY-3598
> URL: https://issues.apache.org/jira/browse/DERBY-3598
> Project: Derby
> Issue Type: Improvement
> Components: Build tools
> Affects Versions: 10.4.1.3
> Reporter: Dyre Tjeldvoll
> Priority: Minor
> Attachments: derby-3598.diff, derby-3598.v2.diff, derby-3598.v2.stat, DERBY-3598.v3.diff
>
>
> Since we cannot create a Jira filter which selects issues with a set fix versions and at the same time EXCLUDE issues with another set of fix versions, it would be nice if the *Generator programs could filter out those issues already fixed in previously released versions.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-3598) Modify ReleaseNoteGenerator and
ChangesGenerator to exclude issues that are fixed in earlier releases
Posted by "Dyre Tjeldvoll (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3598?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dyre Tjeldvoll updated DERBY-3598:
----------------------------------
Attachment: derby-3598.diff
Small hack that has worked well for the 10.4 release work. Admittedly not the most elegant solution, but it seems to work.
> Modify ReleaseNoteGenerator and ChangesGenerator to exclude issues that are fixed in earlier releases
> -----------------------------------------------------------------------------------------------------
>
> Key: DERBY-3598
> URL: https://issues.apache.org/jira/browse/DERBY-3598
> Project: Derby
> Issue Type: Improvement
> Components: Build tools
> Affects Versions: 10.4.1.0
> Reporter: Dyre Tjeldvoll
> Assignee: Dyre Tjeldvoll
> Priority: Minor
> Fix For: 10.5.0.0
>
> Attachments: derby-3598.diff
>
>
> Since we cannot create a Jira filter which selects issues with a set fix versions and at the same time EXCLUDE issues with another set of fix versions, it would be nice if the *Generator programs could filter out those issues already fixed in previously released versions.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-3598) Modify ReleaseNoteGenerator and
ChangesGenerator to exclude issues that are fixed in earlier releases
Posted by "Rick Hillegas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12717355#action_12717355 ]
Rick Hillegas commented on DERBY-3598:
--------------------------------------
Thanks for tackling this issue, Myrna. I am unable to comment on the code changes. The edits are largely stylistic and refactoring changes, which obscure the functional improvements. If there is a particular functional change or design decision which you'd like to draw my attention to, please let me know. Thanks.
> Modify ReleaseNoteGenerator and ChangesGenerator to exclude issues that are fixed in earlier releases
> -----------------------------------------------------------------------------------------------------
>
> Key: DERBY-3598
> URL: https://issues.apache.org/jira/browse/DERBY-3598
> Project: Derby
> Issue Type: Improvement
> Components: Build tools
> Affects Versions: 10.4.1.3
> Reporter: Dyre Tjeldvoll
> Priority: Minor
> Attachments: derby-3598.diff, derby-3598.v2.diff, derby-3598.v2.stat, DERBY-3598.v3.diff, DERBY-3598.v4.diff, RELEASE-NOTES.html
>
>
> Since we cannot create a Jira filter which selects issues with a set fix versions and at the same time EXCLUDE issues with another set of fix versions, it would be nice if the *Generator programs could filter out those issues already fixed in previously released versions.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.