You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/07/01 17:19:47 UTC
[GitHub] [arrow] saethlin opened a new pull request #7610: ARROW-9290: [Rust] [Parquet] Add features to allow opting out of dependencies
saethlin opened a new pull request #7610:
URL: https://github.com/apache/arrow/pull/7610
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] sunchao commented on a change in pull request #7610: ARROW-9290: [Rust] [Parquet] Add features to allow opting out of dependencies
Posted by GitBox <gi...@apache.org>.
sunchao commented on a change in pull request #7610:
URL: https://github.com/apache/arrow/pull/7610#discussion_r449204149
##########
File path: rust/parquet/Cargo.toml
##########
@@ -29,20 +29,29 @@ build = "build.rs"
edition = "2018"
[dependencies]
-parquet-format = "~2.6"
+parquet-format = "2.6.1"
Review comment:
Cool. Didn't know that. I think it should be fine to change to 2.6.1.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #7610: ARROW-9290: [Rust] [Parquet] Add features to allow opting out of dependencies
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #7610:
URL: https://github.com/apache/arrow/pull/7610#issuecomment-652553010
https://issues.apache.org/jira/browse/ARROW-9290
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] sunchao closed pull request #7610: ARROW-9290: [Rust] [Parquet] Add features to allow opting out of dependencies
Posted by GitBox <gi...@apache.org>.
sunchao closed pull request #7610:
URL: https://github.com/apache/arrow/pull/7610
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] saethlin commented on a change in pull request #7610: ARROW-9290: [Rust] [Parquet] Add features to allow opting out of dependencies
Posted by GitBox <gi...@apache.org>.
saethlin commented on a change in pull request #7610:
URL: https://github.com/apache/arrow/pull/7610#discussion_r449038314
##########
File path: rust/parquet/Cargo.toml
##########
@@ -29,20 +29,29 @@ build = "build.rs"
edition = "2018"
[dependencies]
-parquet-format = "~2.6"
+parquet-format = "2.6.1"
Review comment:
parquet-format 2.6.0 depends on thrift 0.12, which declares all its dependencies with ~ which is overly restrictive. Specifically, recent versions of the bincode crate declares a dependency on byteorder ^1.3 but thrift 0.12 declares a dependency on byteorder ~1.2 which is a requirement that cannot be resolved.
parquet-format 2.6.1 bumps to thrift 0.13 which no longer uses ~ for its dependencies.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] saethlin commented on a change in pull request #7610: ARROW-9290: [Rust] [Parquet] Add features to allow opting out of dependencies
Posted by GitBox <gi...@apache.org>.
saethlin commented on a change in pull request #7610:
URL: https://github.com/apache/arrow/pull/7610#discussion_r449168566
##########
File path: rust/parquet/Cargo.toml
##########
@@ -29,20 +29,29 @@ build = "build.rs"
edition = "2018"
[dependencies]
-parquet-format = "~2.6"
+parquet-format = "2.6.1"
Review comment:
I don't know for certain. Things _might_ work with `~2.6`, but that does not forbid Cargo from selecting `2.6.0` and I've recently been fighting a lot with a few problems that arise because `cargo publish` runs `cargo update` and crate maintainers in general tend to update their lockfiles often.
Here's an example of a similar (but not exactly the same) problem, where the dependency specification includes things that do and don't compile: https://github.com/achanda/ipnetwork/issues/132
My perspective is that I'd rather be safe than sorry, but if you'd rather be conservative in what gets changed in the project I understand and I have no problem with opening a separate PR when this causes problems.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] sunchao commented on a change in pull request #7610: ARROW-9290: [Rust] [Parquet] Add features to allow opting out of dependencies
Posted by GitBox <gi...@apache.org>.
sunchao commented on a change in pull request #7610:
URL: https://github.com/apache/arrow/pull/7610#discussion_r449157156
##########
File path: rust/parquet/Cargo.toml
##########
@@ -29,20 +29,29 @@ build = "build.rs"
edition = "2018"
[dependencies]
-parquet-format = "~2.6"
+parquet-format = "2.6.1"
Review comment:
Understood about the need to update to thrift 0.13. However I thought the semver `~2.6` is equivalent to`>=2.6.0 < 2.7.0` so it will automatically pick up 2.6.1. Is that not the case?
##########
File path: rust/parquet/Cargo.toml
##########
@@ -29,20 +29,29 @@ build = "build.rs"
edition = "2018"
[dependencies]
-parquet-format = "~2.6"
+parquet-format = "2.6.1"
Review comment:
Understood the need to update to thrift 0.13. However I thought the semver `~2.6` is equivalent to`>=2.6.0 < 2.7.0` so it will automatically pick up 2.6.1. Is that not the case?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] saethlin commented on a change in pull request #7610: ARROW-9290: [Rust] [Parquet] Add features to allow opting out of dependencies
Posted by GitBox <gi...@apache.org>.
saethlin commented on a change in pull request #7610:
URL: https://github.com/apache/arrow/pull/7610#discussion_r449168566
##########
File path: rust/parquet/Cargo.toml
##########
@@ -29,20 +29,29 @@ build = "build.rs"
edition = "2018"
[dependencies]
-parquet-format = "~2.6"
+parquet-format = "2.6.1"
Review comment:
I don't know for certain. Things _might_ work with `~2.6`, but that does not forbid Cargo from selecting `2.6.0` and I've recently been fighting a lot with a few problems that arise because `cargo publish` runs `cargo update` and crate maintainers in general tend to update their lockfiles often, so sometimes a `Cargo.toml` dependency requirement includes options that are invalid.
Here's an example of a similar (but not exactly the same) problem, where the dependency specification includes things that do and don't compile: https://github.com/achanda/ipnetwork/issues/132
My perspective is that I'd rather be safe than sorry, but if you'd rather be conservative in what gets changed in the project I understand and I have no problem with opening a separate PR when this causes problems.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] sunchao commented on a change in pull request #7610: ARROW-9290: [Rust] [Parquet] Add features to allow opting out of dependencies
Posted by GitBox <gi...@apache.org>.
sunchao commented on a change in pull request #7610:
URL: https://github.com/apache/arrow/pull/7610#discussion_r448553159
##########
File path: rust/parquet/Cargo.toml
##########
@@ -29,20 +29,29 @@ build = "build.rs"
edition = "2018"
[dependencies]
-parquet-format = "~2.6"
+parquet-format = "2.6.1"
Review comment:
Why this change?
##########
File path: rust/parquet/Cargo.toml
##########
@@ -29,20 +29,29 @@ build = "build.rs"
edition = "2018"
[dependencies]
-parquet-format = "~2.6"
+parquet-format = "2.6.1"
quick-error = "1.2"
Review comment:
We can remove this dependency now?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org