You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Andrei Sekretenko <as...@mesosphere.io> on 2020/04/15 20:05:40 UTC
Re: Review Request 72273: Split out exec.hpp from shell.hpp in stout.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72273/#review220323
-----------------------------------------------------------
Ship it!
Ship It!
- Andrei Sekretenko
On March 30, 2020, 8:14 p.m., Benjamin Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72273/
> -----------------------------------------------------------
>
> (Updated March 30, 2020, 8:14 p.m.)
>
>
> Review request for mesos, Andrei Sekretenko and Greg Mann.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> shell.hpp included both shell command execution (i.e. `sh -c '...'`
> and `cmd.exe /c ...`) and non-shell command execution (i.e. fork/exec
> with explicit arguments and CreateProcess with explicit command line).
>
> This is rather confusing, since the latter of the two does not involve
> a shell. To make this clearer, we split the exec style utilities into
> their own header.
>
> This also helps set up some simpler diffs for fixing windows command
> execution, see MESOS-10093.
>
>
> Diffs
> -----
>
> 3rdparty/stout/include/Makefile.am 29dbf9999a4de51f2e0d39f4af7b312ad05884d8
> 3rdparty/stout/include/stout/os.hpp 15cbb50d91f73ea5c7c94863b2bca430fa2a6e26
> 3rdparty/stout/include/stout/os/exec.hpp PRE-CREATION
> 3rdparty/stout/include/stout/os/posix/chown.hpp 644129e9f89d66893ab3f7e677447e0dabf9e333
> 3rdparty/stout/include/stout/os/posix/copyfile.hpp 40b9e4712fdaaeb36f9db2a1e96fe5985e73557c
> 3rdparty/stout/include/stout/os/posix/exec.hpp PRE-CREATION
> 3rdparty/stout/include/stout/os/posix/shell.hpp 2cc4e2cd206e9d91541dfad1e7eb2da213188420
> 3rdparty/stout/include/stout/os/windows/exec.hpp PRE-CREATION
> 3rdparty/stout/include/stout/os/windows/shell.hpp 2f76bbaac9032906c544010c55cdcbe3d7b03d23
> 3rdparty/stout/include/stout/posix/os.hpp 91ef5bc494a45d37bf3fc1aa0a0be0293fcfd7f1
> 3rdparty/stout/tests/os/process_tests.cpp add8ed68782a3385bd33134541b070b2175d9ed3
> 3rdparty/stout/tests/os/rmdir_tests.cpp 9ca4d9605b0f3aa645c424f911f4108d125f6c9c
> 3rdparty/stout/tests/os_tests.cpp f1cfe5cb3750f1bfefdd77962150551c361ac0b7
>
>
> Diff: https://reviews.apache.org/r/72273/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Mahler
>
>