[GitHub] [hbase] infraio commented on a change in pull request #1916: HBASE-24546 CloneSnapshotProcedure unlimited retry

[GitBox <gi...@apache.org>]

infraio commented on a change in pull request #1916:
URL: https://github.com/apache/hbase/pull/1916#discussion_r441422204



##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/CloneSnapshotProcedure.java
##########
@@ -457,6 +457,10 @@ private void postCloneSnapshot(final MasterProcedureEnv env)
     // 1. Create Table Descriptor
     // using a copy of descriptor, table will be created enabling first
     final Path tempTableDir = FSUtils.getTableDir(tempdir, tableDescriptor.getTableName());
+    if (FSUtils.isExists(mfs.getFileSystem(), tempTableDir)) {
+      LOG.warn("temp table dir already exists on disk: {}, will be deleted.", tempTableDir);
+      FSUtils.deleteDirectory(mfs.getFileSystem(), tempTableDir);
+    }

Review comment:
       The problem is: the retry will never succeed if the region dirs exist? Add comment here?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org