You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@activemq.apache.org by "cshannon (via GitHub)" <gi...@apache.org> on 2026/03/25 15:56:41 UTC
[PR] Fix FactoryFinder path resolution in Windows [activemq]
cshannon opened a new pull request, #1831:
URL: https://github.com/apache/activemq/pull/1831
Closes #1830
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For additional commands, e-mail: gitbox-help@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
Re: [PR] Fix FactoryFinder path resolution in Windows [activemq]
Posted by "cshannon (via GitHub)" <gi...@apache.org>.
cshannon commented on PR #1831:
URL: https://github.com/apache/activemq/pull/1831#issuecomment-4127790804
@wilkinsona - This is currently on the main branch (6.3.0-SNAPSHOT) and can be backported to the other branches for 6.2.3.
Do you have an easy way to test a snapshot to verify this fixes the issue? Interestingly it didn't show up in our Github actions Windows CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For additional commands, e-mail: gitbox-help@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
Re: [PR] Fix FactoryFinder path resolution in Windows [activemq]
Posted by "cshannon (via GitHub)" <gi...@apache.org>.
cshannon merged PR #1831:
URL: https://github.com/apache/activemq/pull/1831
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For additional commands, e-mail: gitbox-help@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
Re: [PR] Fix FactoryFinder path resolution in Windows [activemq]
Posted by "cshannon (via GitHub)" <gi...@apache.org>.
cshannon commented on PR #1831:
URL: https://github.com/apache/activemq/pull/1831#issuecomment-4129460386
I need to make a tweak here as I realized by the startsWith() check that is done inside of resolvePath() should really be done after the final path is resolved (and any slashes are replaced) to make sure the actual final path that will be used gets validated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For additional commands, e-mail: gitbox-help@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
Re: [PR] Fix FactoryFinder path resolution in Windows [activemq]
Posted by "cshannon (via GitHub)" <gi...@apache.org>.
cshannon commented on PR #1831:
URL: https://github.com/apache/activemq/pull/1831#issuecomment-4134754321
> @cshannon you can see the [failures for our CI build](https://github.com/spring-projects/spring-boot/actions/runs/23548119491). The upgrade fails on JDK 17, 21, 25, and 26 (Liberica) on Microsoft Windows Server 2025 (10.0.26100).
>
> Perhaps the above would help you reproduce?
@snicoll - Thanks for pointing that out, that was very helpful!
I cloned Spring Boot and ran the ActiveMQ tests against 6.2.2 with the same JDK and was able to reproduce the test failure as soon in the logs in your CI builds, so that was good news I could reproduce it. I then updated my local spring boot build to use a snapshot ActiveMQ build based on this PR and I confirmed the test now passes again and is fixed.
I will go ahead and merge this and we will get a 6.2.3 build out soon that will include this fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For additional commands, e-mail: gitbox-help@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
Re: [PR] Fix FactoryFinder path resolution in Windows [activemq]
Posted by "wilkinsona (via GitHub)" <gi...@apache.org>.
wilkinsona commented on PR #1831:
URL: https://github.com/apache/activemq/pull/1831#issuecomment-4128330619
> Do you have an easy way to test a snapshot to verify this fixes the issue? Interestingly it didn't show up in our Github actions Windows CI.
Unfortunately not. Through GitHub Actions is the only way that I have to run tests on Windows so I'd have to set up a special CI build with access to ActiveMQ snapshots.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For additional commands, e-mail: gitbox-help@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
Re: [PR] Fix FactoryFinder path resolution in Windows [activemq]
Posted by "snicoll (via GitHub)" <gi...@apache.org>.
snicoll commented on PR #1831:
URL: https://github.com/apache/activemq/pull/1831#issuecomment-4132878580
@cshannon you can see the [failures for our CI build](https://github.com/spring-projects/spring-boot/actions/runs/23548119491). The upgrade fails on JDK 17, 21, 25, and 26 (Liberica) on Microsoft Windows Server 2025 (10.0.26100).
Perhaps the above would help you reproduce?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For additional commands, e-mail: gitbox-help@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
Re: [PR] Fix FactoryFinder path resolution in Windows [activemq]
Posted by "cshannon (via GitHub)" <gi...@apache.org>.
cshannon commented on PR #1831:
URL: https://github.com/apache/activemq/pull/1831#issuecomment-4130260777
@jbonofre - Ok assuming CI passes I think this is good, I added some extra tests for backward slashes and also validation for path separators in the name of the key as an extra check.
I think the root cause here has to do with differing versions of Windows and the JDK. I tested with Temurin JDK 25 on windows and everything works fine even with backslashes, so I'm guessing it depends on the exact environment. Replacing the backslashes should restore the previous behavior before we normalized and should hopefully fix the issue.
Once this is merged we can backport and create a 6.2.3 and 5.19.4 release
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For additional commands, e-mail: gitbox-help@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact