[GitHub] [incubator-seatunnel] lightzhao commented on pull request #4469: [Bug][Connector-v2][KafkaSink][Problems relating to commiting transactions under EXACTLY_ONCE semantics]

["lightzhao (via GitHub)" <gi...@apache.org>]

lightzhao commented on PR #4469:
URL: https://github.com/apache/incubator-seatunnel/pull/4469#issuecomment-1493310742

   > > `ReflectionUtils.setField(transactionManager, "transactionStarted", true);` we need to additionally persist this transactionStarted flag in checkpoints as part of the KafkaCommitInfo metadata. And then set this flag appropriately to what is stored in the checkpoint. If it is an empty transaction, the transactionStarted flag should be set to false.
   > 
   > I think that's a better way to fix the Problem 3, and tested well in my machine.
   > 
   > When transactionStarted is set to false, KafkaProducer will close the transaction locally without sending the EndTxn request to kafka servers, so the problem will not appear.
   > 
   > I have changed my pr. @lightzhao
   
   great, please add e2e test.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org