[GitHub] mistercrunch commented on a change in pull request #5686: Force quoted column aliases for Oracle-like databases

[GitBox <gi...@apache.org>]

mistercrunch commented on a change in pull request #5686: Force quoted column aliases for Oracle-like databases
URL: https://github.com/apache/incubator-superset/pull/5686#discussion_r212864262
 
 

 ##########
 File path: superset/connectors/sqla/models.py
 ##########
 @@ -99,21 +104,20 @@ class TableColumn(Model, BaseColumn):
         s for s in export_fields if s not in ('table_id',)]
     export_parent = 'table'
 
-    @property
-    def sqla_col(self):
-        name = self.column_name
+    def sqla_col(self, db_engine_spec, label=None):
 
 Review comment:
   I think `db_engine_spec` is available through `self.table.database.db_engine_spec`, so no need to receive it as a method argument.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org