[GitHub] [arrow-datafusion] alamb commented on a diff in pull request #2317: Fix HashJoin evaluating during plan

[GitBox <gi...@apache.org>]

alamb commented on code in PR #2317:
URL: https://github.com/apache/arrow-datafusion/pull/2317#discussion_r858571316


##########
datafusion/core/src/physical_plan/hash_join.rs:
##########
@@ -979,21 +953,40 @@ fn produce_from_matched(
     RecordBatch::try_new(schema.clone(), columns)
 }
 
-impl Stream for HashJoinStream {
-    type Item = ArrowResult<RecordBatch>;
-
-    fn poll_next(
-        mut self: std::pin::Pin<&mut Self>,
+impl HashJoinStream {
+    /// Separate implementation function that unpins the [`CrossJoinStream`] so

Review Comment:
   ```suggestion
       /// Separate implementation function that unpins the [`HashJoinStream`] so
   ```



##########
datafusion/core/src/physical_plan/cross_join.rs:
##########
@@ -34,24 +33,19 @@ use super::{
 };
 use crate::{error::Result, scalar::ScalarValue};
 use async_trait::async_trait;
-use futures::future::{BoxFuture, Shared};
 use std::time::Instant;
 
 use super::{
     coalesce_batches::concat_batches, DisplayFormatType, ExecutionPlan, Partitioning,
     RecordBatchStream, SendableRecordBatchStream,
 };
 use crate::execution::context::TaskContext;
+use crate::physical_plan::join_utils::{OnceAsync, OnceFut};

Review Comment:
   👍 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org