You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "yjshen (via GitHub)" <gi...@apache.org> on 2023/09/14 15:55:08 UTC

[GitHub] [arrow-datafusion] yjshen commented on pull request #7400: feat: Support spilling for hash aggregation

yjshen commented on PR #7400:
URL: https://github.com/apache/arrow-datafusion/pull/7400#issuecomment-1719722490

   On a M2 Max Mac:
   ```
   --------------------
   Benchmark tpch.json
   --------------------
   
   
   ┏━━━━━━━━━━━━━━┳━━━━━━━━━━┳━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━┓
   ┃ Query        ┃     main ┃ agg-spill-pr ┃       Change ┃
   ┡━━━━━━━━━━━━━━╇━━━━━━━━━━╇━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━┩
   │ QQuery 1     │ 373.61ms │     379.52ms │    no change │
   │ QQuery 2     │  54.07ms │      71.85ms │ 1.33x slower │
   │ QQuery 3     │ 127.28ms │     125.39ms │    no change │
   │ QQuery 4     │  77.72ms │      77.59ms │    no change │
   │ QQuery 5     │ 153.95ms │     155.71ms │    no change │
   │ QQuery 6     │  74.79ms │      75.29ms │    no change │
   │ QQuery 7     │ 215.22ms │     217.05ms │    no change │
   │ QQuery 8     │ 181.37ms │     182.10ms │    no change │
   │ QQuery 9     │ 255.84ms │     254.07ms │    no change │
   │ QQuery 10    │ 201.64ms │     204.14ms │    no change │
   │ QQuery 11    │  50.53ms │      51.22ms │    no change │
   │ QQuery 12    │ 136.34ms │     133.59ms │    no change │
   │ QQuery 13    │ 209.86ms │     213.03ms │    no change │
   │ QQuery 14    │ 107.24ms │     110.68ms │    no change │
   │ QQuery 15    │  77.42ms │      78.31ms │    no change │
   │ QQuery 16    │  46.33ms │      46.21ms │    no change │
   │ QQuery 17    │ 165.80ms │     167.61ms │    no change │
   │ QQuery 18    │ 308.12ms │     299.10ms │    no change │
   │ QQuery 19    │ 206.49ms │     207.36ms │    no change │
   │ QQuery 20    │ 120.51ms │     122.26ms │    no change │
   │ QQuery 21    │ 319.92ms │     325.50ms │    no change │
   │ QQuery 22    │  47.27ms │      46.02ms │    no change │
   └──────────────┴──────────┴──────────────┴──────────────┘
   
   --------------------
   Benchmark tpch_mem.json
   --------------------
   
   ┏━━━━━━━━━━━━━━┳━━━━━━━━━━┳━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━┓
   ┃ Query        ┃     main ┃ agg-spill-pr ┃       Change ┃
   ┡━━━━━━━━━━━━━━╇━━━━━━━━━━╇━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━┩
   │ QQuery 1     │ 249.33ms │     249.81ms │    no change │
   │ QQuery 2     │  34.74ms │      43.41ms │ 1.25x slower │
   │ QQuery 3     │  45.14ms │      45.13ms │    no change │
   │ QQuery 4     │  35.32ms │      35.42ms │    no change │
   │ QQuery 5     │  90.31ms │      89.50ms │    no change │
   │ QQuery 6     │   9.60ms │       9.50ms │    no change │
   │ QQuery 7     │ 172.73ms │     178.81ms │    no change │
   │ QQuery 8     │  69.94ms │      68.29ms │    no change │
   │ QQuery 9     │ 131.35ms │     126.52ms │    no change │
   │ QQuery 10    │  84.17ms │      86.08ms │    no change │
   │ QQuery 11    │  37.16ms │      36.25ms │    no change │
   │ QQuery 12    │  57.98ms │      57.18ms │    no change │
   │ QQuery 13    │  93.57ms │      92.33ms │    no change │
   │ QQuery 14    │  11.52ms │      11.62ms │    no change │
   │ QQuery 15    │  13.57ms │      14.29ms │ 1.05x slower │
   │ QQuery 16    │  36.73ms │      38.23ms │    no change │
   │ QQuery 17    │  74.55ms │      74.09ms │    no change │
   │ QQuery 18    │ 248.72ms │     242.23ms │    no change │
   │ QQuery 19    │  50.12ms │      50.65ms │    no change │
   │ QQuery 20    │  73.09ms │      73.83ms │    no change │
   │ QQuery 21    │ 240.83ms │     231.30ms │    no change │
   │ QQuery 22    │  27.21ms │      27.18ms │    no change │
   └──────────────┴──────────┴──────────────┴──────────────┘
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org