You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hc.apache.org by GitBox <gi...@apache.org> on 2020/08/04 17:45:46 UTC
[GitHub] [httpcomponents-core] carterkozak opened a new pull request #210: HTTPCORE-639: Partially revert expensive early-response checks
carterkozak opened a new pull request #210:
URL: https://github.com/apache/httpcomponents-core/pull/210
This patch mostly restores the behavior of hc 4.x releases in
which large early responses can result in the client blocking until
a socket exception is thrown. Behavior of plain http detection
is not modified, but only works prior to jre13 due to
http://openjdk.java.net/jeps/353.
This behavior will be configurable in 5.1 releases, but has been
removed as the result of a request entity performance regression
that limited any request to at minimum a full millisecond and at
most 8 MiB/second upload speed regardless of the network.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-core] michael-o edited a comment on pull request #210: HTTPCORE-639: Partially revert expensive early-response checks
Posted by GitBox <gi...@apache.org>.
michael-o edited a comment on pull request #210:
URL: https://github.com/apache/httpcomponents-core/pull/210#issuecomment-668736085
I am not convinced that this is a good idea. It should either work consistently accross protocols or nothing at all.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-core] michael-o commented on pull request #210: HTTPCORE-639: Partially revert expensive early-response checks
Posted by GitBox <gi...@apache.org>.
michael-o commented on pull request #210:
URL: https://github.com/apache/httpcomponents-core/pull/210#issuecomment-668736085
I am not convinced that this is a good idea at all. It should either work consistently accross protocols or nothing at all.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-core] carterkozak commented on pull request #210: HTTPCORE-639: Partially revert expensive early-response checks
Posted by GitBox <gi...@apache.org>.
carterkozak commented on pull request #210:
URL: https://github.com/apache/httpcomponents-core/pull/210#issuecomment-668738652
I'm conflicted about the backport. On one hand It's helpful to minimize impact in bugfix releases, if we can avoid changing behavior for users without TLS, that could be helpful. On the other hand I agree that it's confusing to support this feature in some non-obvious configurations, it's common to run tests without ssl and we wouldn't want to create a false sense of security.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-core] carterkozak closed pull request #210: HTTPCORE-639: Partially revert expensive early-response checks
Posted by GitBox <gi...@apache.org>.
carterkozak closed pull request #210:
URL: https://github.com/apache/httpcomponents-core/pull/210
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-core] michael-o commented on pull request #210: HTTPCORE-639: Partially revert expensive early-response checks
Posted by GitBox <gi...@apache.org>.
michael-o commented on pull request #210:
URL: https://github.com/apache/httpcomponents-core/pull/210#issuecomment-668745443
I think we have tests for TLS too since ALPN is tested. We can consider the implementation in 5.0.x after this PR as naive as for the SHOULD in the RFC. No guarantees made.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-core] carterkozak commented on pull request #210: HTTPCORE-639: Partially revert expensive early-response checks
Posted by GitBox <gi...@apache.org>.
carterkozak commented on pull request #210:
URL: https://github.com/apache/httpcomponents-core/pull/210#issuecomment-669135762
Thanks, I'm closing this because a3870ef2808cd78c9c3d849df6ee56b2ef8a4f95 has been committed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org