You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/02/22 20:24:26 UTC
[GitHub] [superset] hughhhh commented on a change in pull request #13288: fix(sqllab): per-tab hide left bar
hughhhh commented on a change in pull request #13288:
URL: https://github.com/apache/superset/pull/13288#discussion_r580565212
##########
File path: superset-frontend/src/SqlLab/actions/sqlLab.js
##########
@@ -663,6 +664,36 @@ export function setActiveSouthPaneTab(tabId) {
return { type: SET_ACTIVE_SOUTHPANE_TAB, tabId };
}
+export function toggleLeftBar(queryEditor) {
+ const hideLeftBar = !queryEditor.hideLeftBar;
+ return function (dispatch) {
+ const sync = isFeatureEnabled(FeatureFlag.SQLLAB_BACKEND_PERSISTENCE)
+ ? SupersetClient.put({
Review comment:
can we use `makeApi` here instead of `SupersetClient` directly
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org