[GitHub] [nifi] sedadgn commented on pull request #5458: NIFI-7865 amqp$header is splitted in the wrong way for "," and "}"

[GitBox <gi...@apache.org>]

sedadgn commented on pull request #5458:
URL: https://github.com/apache/nifi/pull/5458#issuecomment-1012994358


   > I'm not convinced that adding guava is necessary just for the split/join use case (I was ok with the previous logic, although perhaps it could be refactored out into a dedicated joinMap/splitMap helper method), but if you do want to stick with guava, it looks to me like most other NARs that bundle it call that out in the NOTICE file in the `nifi-*-bundle/nifi-*-nar/src/main/resources/META-INF/` directory, so that would probably be required in this case as well.
   > 
   > Everything else looks good to me aside from one minor comment about code organization in StandardValidators.
   
   Hello @kevdoran ,
   Thank you very much for your review.
   I removed guava and added 2 methods for splitMap/joinMap.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org