[GitHub] [bahir-flink] hackergin commented on a change in pull request #109: [BAHIR-260] add kudu table writer config.

[GitBox <gi...@apache.org>]

hackergin commented on a change in pull request #109:
URL: https://github.com/apache/bahir-flink/pull/109#discussion_r602907335



##########
File path: flink-connector-kudu/src/main/java/org/apache/flink/connectors/kudu/connector/writer/KuduWriterConfig.java
##########
@@ -65,6 +101,11 @@ public String toString() {
     public static class Builder {
         private String masters;
         private FlushMode flushMode = FlushMode.AUTO_FLUSH_BACKGROUND;
+        private long timeout = 30000;
+        private int maxBufferSize = 1000;
+        private int flushInterval = 1000;

Review comment:
       These are from https://github.com/apache/kudu/blob/1eb2a2fbca/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduSession.java and  https://github.com/apache/kudu/blob/1eb2a2fbca/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java.  So, It will not affect the out of box performance.  I can add some  Annotation for them.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org