You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gobblin.apache.org by "vikrambohra (via GitHub)" <gi...@apache.org> on 2023/03/31 22:21:09 UTC
[GitHub] [gobblin] vikrambohra opened a new pull request, #3666: [GOBBLIN-1805] Check watermark for the most recent hour for quiet topics
vikrambohra opened a new pull request, #3666:
URL: https://github.com/apache/gobblin/pull/3666
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
### JIRA
- [ ] My PR addresses the following [Gobblin JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
- https://issues.apache.org/jira/browse/GOBBLIN-1805
### Description
- [ ] Here are some details about my PR, including screenshots (if applicable):
Currently, Audit check is done for [currentWatermark, currentWatermark +1hour] window for quiet topics. However when the audit check for this window fails (due to an upstream bug in audit), the watermark never progress as the currentWatermark is never updated. To avoid this we keep progressing the watermark by checking the window [currentHour -1, currentHour] window
### Tests
- Updated unit test to reflect this change
### Commits
- [ ] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
2. Subject is limited to 50 characters
3. Subject does not end with a period
4. Subject uses the imperative mood ("add", not "adding")
5. Body wraps at 72 characters
6. Body explains "what" and "why", not "how"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@gobblin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [gobblin] vikrambohra closed pull request #3666: [GOBBLIN-1805] Check watermark for the most recent hour for quiet topics
Posted by "vikrambohra (via GitHub)" <gi...@apache.org>.
vikrambohra closed pull request #3666: [GOBBLIN-1805] Check watermark for the most recent hour for quiet topics
URL: https://github.com/apache/gobblin/pull/3666
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@gobblin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [gobblin] codecov-commenter commented on pull request #3666: [GOBBLIN-1805] Check watermark for the most recent hour for quiet topics
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #3666:
URL: https://github.com/apache/gobblin/pull/3666#issuecomment-1496785526
## [Codecov](https://codecov.io/gh/apache/gobblin/pull/3666?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#3666](https://codecov.io/gh/apache/gobblin/pull/3666?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e24261a) into [master](https://codecov.io/gh/apache/gobblin/commit/7675dc43dd7128bb2daedb8c6b826e8fcc9104c7?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7675dc4) will **increase** coverage by `4.16%`.
> The diff coverage is `0.00%`.
```diff
@@ Coverage Diff @@
## master #3666 +/- ##
============================================
+ Coverage 46.97% 51.14% +4.16%
+ Complexity 10780 7210 -3570
============================================
Files 2138 1345 -793
Lines 83992 50652 -33340
Branches 9332 5630 -3702
============================================
- Hits 39455 25904 -13551
+ Misses 40959 22487 -18472
+ Partials 3578 2261 -1317
```
| [Impacted Files](https://codecov.io/gh/apache/gobblin/pull/3666?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...obblin/service/FlowConfigResourceLocalHandler.java](https://codecov.io/gh/apache/gobblin/pull/3666?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1yZXN0bGkvZ29iYmxpbi1mbG93LWNvbmZpZy1zZXJ2aWNlL2dvYmJsaW4tZmxvdy1jb25maWctc2VydmljZS1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vc2VydmljZS9GbG93Q29uZmlnUmVzb3VyY2VMb2NhbEhhbmRsZXIuamF2YQ==) | `12.40% <0.00%> (-3.29%)` | :arrow_down: |
| [...blin/service/FlowConfigV2ResourceLocalHandler.java](https://codecov.io/gh/apache/gobblin/pull/3666?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1yZXN0bGkvZ29iYmxpbi1mbG93LWNvbmZpZy1zZXJ2aWNlL2dvYmJsaW4tZmxvdy1jb25maWctc2VydmljZS1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vc2VydmljZS9GbG93Q29uZmlnVjJSZXNvdXJjZUxvY2FsSGFuZGxlci5qYXZh) | `0.00% <ø> (ø)` | |
... and [795 files with indirect coverage changes](https://codecov.io/gh/apache/gobblin/pull/3666/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@gobblin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org