You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2020/09/30 02:37:19 UTC
[GitHub] [lucene-solr] noblepaul opened a new pull request #1932: Reuse crypto keys in reference impl
noblepaul opened a new pull request #1932:
URL: https://github.com/apache/lucene-solr/pull/1932
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] markrmiller commented on a change in pull request #1932: Reuse crypto keys in reference impl
Posted by GitBox <gi...@apache.org>.
markrmiller commented on a change in pull request #1932:
URL: https://github.com/apache/lucene-solr/pull/1932#discussion_r497827861
##########
File path: solr/test-framework/src/java/org/apache/solr/SolrTestCase.java
##########
@@ -225,7 +238,7 @@ public static void setDefaultConfigDirSysPropIfNotSet() throws Exception {
System.setProperty("solr.clustering.enabled", "false");
System.setProperty("solr.peerSync.useRangeVersions", String.valueOf(random().nextBoolean()));
System.setProperty("zookeeper.nio.directBufferBytes", Integer.toString(32 * 1024 * 2));
- System.setProperty("solr.disablePublicKeyHandler", "true");
+ enableReuseOfCryptoKeys();
if (!TEST_NIGHTLY) {
Review comment:
Let's enable reuse here instead.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] markrmiller commented on a change in pull request #1932: Reuse crypto keys in reference impl
Posted by GitBox <gi...@apache.org>.
markrmiller commented on a change in pull request #1932:
URL: https://github.com/apache/lucene-solr/pull/1932#discussion_r497827172
##########
File path: solr/test-framework/src/java/org/apache/solr/SolrTestCase.java
##########
@@ -279,7 +292,6 @@ public static void setDefaultConfigDirSysPropIfNotSet() throws Exception {
System.setProperty("solr.http2solrclient.maxpool.size", "12");
System.setProperty("solr.http2solrclient.pool.keepalive", "1500");
Review comment:
Let's enable reuse here instead.
##########
File path: solr/test-framework/src/java/org/apache/solr/SolrTestCase.java
##########
@@ -225,7 +238,7 @@ public static void setDefaultConfigDirSysPropIfNotSet() throws Exception {
System.setProperty("solr.clustering.enabled", "false");
System.setProperty("solr.peerSync.useRangeVersions", String.valueOf(random().nextBoolean()));
System.setProperty("zookeeper.nio.directBufferBytes", Integer.toString(32 * 1024 * 2));
- System.setProperty("solr.disablePublicKeyHandler", "true");
+ enableReuseOfCryptoKeys();
Review comment:
Looks like I had this reversed. We should likely enable reuse below in the non Nightly run and disable for the closer to prod Nightly run.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] madrob commented on a change in pull request #1932: Reuse crypto keys in reference impl
Posted by GitBox <gi...@apache.org>.
madrob commented on a change in pull request #1932:
URL: https://github.com/apache/lucene-solr/pull/1932#discussion_r497719525
##########
File path: solr/test-framework/src/java/org/apache/solr/SolrTestCase.java
##########
@@ -124,6 +126,17 @@
protected volatile static PerThreadExecService testExecutor;
+ private static final CryptoKeys.RSAKeyPair reusedKeys = new CryptoKeys.RSAKeyPair();
Review comment:
Why not use the key-pair that's already on disk? See https://github.com/apache/lucene-solr/blob/master/solr/test-framework/src/java/org/apache/solr/SolrTestCaseJ4.java#L289-L290
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] noblepaul merged pull request #1932: Reuse crypto keys in reference impl
Posted by GitBox <gi...@apache.org>.
noblepaul merged pull request #1932:
URL: https://github.com/apache/lucene-solr/pull/1932
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] noblepaul merged pull request #1932: Reuse crypto keys in reference impl
Posted by GitBox <gi...@apache.org>.
noblepaul merged pull request #1932:
URL: https://github.com/apache/lucene-solr/pull/1932
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] noblepaul commented on a change in pull request #1932: Reuse crypto keys in reference impl
Posted by GitBox <gi...@apache.org>.
noblepaul commented on a change in pull request #1932:
URL: https://github.com/apache/lucene-solr/pull/1932#discussion_r497984715
##########
File path: solr/test-framework/src/java/org/apache/solr/SolrTestCase.java
##########
@@ -124,6 +126,17 @@
protected volatile static PerThreadExecService testExecutor;
+ private static final CryptoKeys.RSAKeyPair reusedKeys = new CryptoKeys.RSAKeyPair();
Review comment:
This is for just testcase
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] madrob commented on a change in pull request #1932: Reuse crypto keys in reference impl
Posted by GitBox <gi...@apache.org>.
madrob commented on a change in pull request #1932:
URL: https://github.com/apache/lucene-solr/pull/1932#discussion_r497719279
##########
File path: solr/core/src/java/org/apache/solr/security/PublicKeyHandler.java
##########
@@ -32,18 +32,22 @@
public class PublicKeyHandler extends RequestHandlerBase {
public static final String PATH = "/admin/info/key";
+ //This is an optimization for tests only
+ public static volatile CryptoKeys.RSAKeyPair REUSABLE_KEYPAIR ;
Review comment:
Why not use the key-pair that's already on disk? See https://github.com/apache/lucene-solr/blob/master/solr/test-framework/src/java/org/apache/solr/SolrTestCaseJ4.java#L289-L290
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org