You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Akira Ajisaka (JIRA)" <ji...@apache.org> on 2017/02/15 07:40:41 UTC
[jira] [Commented] (HADOOP-13924) Update checkstyle and checkstyle
plugin version to handle indentation of JDK8 Lambdas
[ https://issues.apache.org/jira/browse/HADOOP-13924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15867395#comment-15867395 ]
Akira Ajisaka commented on HADOOP-13924:
----------------------------------------
Sorry, I've committed with the wrong jira number.
{noformat}
commit 1e11080b7825a2d0bafce91432009f585b7b5d21
Author: Akira Ajisaka <aa...@apache.org>
Date: Wed Feb 15 16:33:30 2017 +0900
HADOOP-13942. Update checkstyle and checkstyle plugin version to handle indentation of JDK8 Lambdas.
{noformat}
HADOOP-13942 should be HADOOP-13924.
> Update checkstyle and checkstyle plugin version to handle indentation of JDK8 Lambdas
> -------------------------------------------------------------------------------------
>
> Key: HADOOP-13924
> URL: https://issues.apache.org/jira/browse/HADOOP-13924
> Project: Hadoop Common
> Issue Type: Bug
> Reporter: Xiaoyu Yao
> Assignee: Akira Ajisaka
> Fix For: 3.0.0-alpha3
>
> Attachments: HADOOP-13924.01.patch
>
>
> Have seen this lately form Jenkins run. Propose add the following to maven checkstyle plugin configuration to better handle this.
> {code}
> <dependency>
> <groupId>com.puppycrawl.tools</groupId>
> <artifactId>checkstyle</artifactId>
> <version>7.3</version>
> </dependency>
> {code}
> {code}
> ./hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java:2049: if (failedVolumes.size() > 0) {: 'if' have incorrect indentation level 10, expected level should be 8.
> ./hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java:2050: LOG.warn("checkDiskErrorAsync callback got {} failed volumes: {}",: 'if' child have incorrect indentation level 12, expected level should be 10.
> ./hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java:2052: } else {: 'if rcurly' have incorrect indentation level 10, expected level should be 8.
> ./hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java:2053: LOG.debug("checkDiskErrorAsync: no volume failures detected");: 'else' child have incorrect indentation level 12, expected level should be 10.
> ./hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java:2054: }: 'else rcurly' have incorrect indentation level 10, expected level should be 8.
> ./hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java:2055: lastDiskErrorCheck = Time.monotonicNow();: 'block' child have incorrect indentation level 10, expected level should be 8.
> ./hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java:2056: handleVolumeFailures(failedVolumes);: 'block' child have incorrect indentation level 10, expected level should be 8.
> ./hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java:2057: });: 'block rcurly' have incorrect indentation level 8, expected level should be 6.
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org