[Bug 57539] New: Secure Sockets (SSL) for TCP Sampler

[bu...@apache.org]

https://issues.apache.org/bugzilla/show_bug.cgi?id=57539

            Bug ID: 57539
           Summary: Secure Sockets (SSL) for TCP Sampler
           Product: JMeter
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P2
         Component: Main
          Assignee: issues@jmeter.apache.org
          Reporter: t.skorka@gmail.com

TCP sampler should also support secure sockets, as systems that use this
connectivity method still exist.
>From UI perspective a simple checkbox labeled "SSL" would do. JKS can be
provided by cmd line parameters (javax.net.ssl.*).

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 57539] Secure Sockets (SSL) for TCP Sampler

[bu...@apache.org]

https://issues.apache.org/bugzilla/show_bug.cgi?id=57539

--- Comment #1 from Tomasz Skórka <t....@gmail.com> ---
Created attachment 32433
  --> https://issues.apache.org/bugzilla/attachment.cgi?id=32433&action=edit
patch_57539

Adding patch for java and docs.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 57539] Secure Sockets (SSL) for TCP Sampler

[bu...@apache.org]

https://issues.apache.org/bugzilla/show_bug.cgi?id=57539

--- Comment #2 from Tomasz Skórka <t....@gmail.com> ---
Created attachment 32434
  --> https://issues.apache.org/bugzilla/attachment.cgi?id=32434&action=edit
docs screenshoot update

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 57539] Secure Sockets (SSL) for TCP Sampler

[bu...@apache.org]

https://issues.apache.org/bugzilla/show_bug.cgi?id=57539

Milamber <mi...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |NEEDINFO

--- Comment #3 from Milamber <mi...@apache.org> ---

Thanks for your patch.

Some comments:

* The TCP sampler fails with a self-signed SSL certificat
Error is:
Response code: 500
Response message: javax.net.ssl.SSLHandshakeException:
sun.security.validator.ValidatorException: PKIX path building failed:
sun.security.provider.certpath.SunCertPathBuilderException: unable to find
valid certification path to requested target

To solve this issue on JMeter, HTTP Sampler or Mail Sampler accepts all SSL
certificate (See class like TrustAllSSLSocketFactory) 

* The documentation must be inserted in component_reference.xml (<-- XML) not
.html. The HTML file is automatically generated by the build script (ant tasks:
docs, printable_docs)

* I think that the key in messages.properties for the checkbox label SSL must
be "tcp_usessl" (not just only "usessl"). The value can be "Use SSL" too (seems
better)

* In the GUI, I think that the "Use SSL" checkbox can be at the first position
(before Re-use connection)

* In TCPConfigGui.java, remove the 'new' comment's lines ("//       
useSsl.addItemListener(new ItemListener() {....). not need I think.

* In TCPSampler.java, in the method " public SampleResult sample(Entry e)", add
to the StringBuilder sb, the key/value for Use SSL (before the reuse value)


Thanks.

-- 
You are receiving this mail because:
You are the assignee for the bug.