You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by "lqxshay (via GitHub)" <gi...@apache.org> on 2023/02/28 01:04:44 UTC

[GitHub] [kafka] lqxshay commented on pull request #13097: Draft: close clean for EOS when it's RUNNING standby or RESTORING active

lqxshay commented on PR #13097:
URL: https://github.com/apache/kafka/pull/13097#issuecomment-1447390999

   @guozhangwang Apologies for the delayed response here. 
   
   Thanks for the explanation. To put it in another way, as long as the task is in certain states(RESTORING active, RUNNING standby task), we would always close clean. I've updated the PR to disregard PendingUpdateAction.Action.CLOSE_DIRTY for the condition in `TaskManager#handlRemovedTasksFromStateUpdater` and `TaskManager#handleRestoredTasksFromStateUpdater`.
   
   Could you please take another look? 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org