You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by GitBox <gi...@apache.org> on 2020/07/22 15:15:49 UTC

[GitHub] [couchdb] jjrodrig opened a new pull request #3022: Port view multi_key js tests into elixir test suite

jjrodrig opened a new pull request #3022:
URL: https://github.com/apache/couchdb/pull/3022


   <!-- Thank you for your contribution!
   
        Please file this form by replacing the Markdown comments
        with your text. If a section needs no action - remove it.
   
        Also remember, that CouchDB uses the Review-Then-Commit (RTC) model
        of code collaboration. Positive feedback is represented +1 from committers
        and negative is a -1. The -1 also means veto, and needs to be addressed
        to proceed. Once there are no objections, the PR can be merged by a
        CouchDB committer.
   
        See: http://couchdb.apache.org/bylaws.html#decisions for more info. -->
   
   ## Overview
   This PR ports the multi key view query related tests into the Elixir test suite:
   - `view_multi_key_all_docs.js` has been ported into `view_multi_key_all_docs_test.exs`
   - `view_multi_key_design.js` has been ported into `view_multi_key_design_test.exs`
   - `view_multi_key_temp.js` has been disabled and not ported as it refers to temporary views which is not supported since 2.x. This test cases is already covered by the previous test cases.
   
   <!-- Please give a short brief for the pull request,
        what problem it solves or how it makes things better. -->
   
   ## Testing recommendations
   ```
    make elixir tests=test/elixir/test/view_multi_key_all_docs_test.exs
    make elixir tests=test/elixir/test/view_multi_key_design_test.exs
   ```
   
   <!-- Describe how we can test your changes.
        Does it provides any behaviour that the end users
        could notice? -->
   
   ## Related Issues or Pull Requests
   N/A
   <!-- If your changes affects multiple components in different
        repositories please put links to those issues or pull requests here.  -->
   
   ## Checklist
   
   - [X] Code is written and works correctly
   - [X] Changes are covered by tests
   - [ ] Any new configurable parameters are documented in `rel/overlay/etc/default.ini`
   - [ ] A PR for documentation changes has been made in https://github.com/apache/couchdb-documentation
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [couchdb] jjrodrig merged pull request #3022: Port view multi_key js tests into elixir test suite

Posted by GitBox <gi...@apache.org>.
jjrodrig merged pull request #3022:
URL: https://github.com/apache/couchdb/pull/3022


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [couchdb] jjrodrig commented on pull request #3022: Port view multi_key js tests into elixir test suite

Posted by GitBox <gi...@apache.org>.
jjrodrig commented on pull request #3022:
URL: https://github.com/apache/couchdb/pull/3022#issuecomment-662843026


   Thanks!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [couchdb] wohali commented on pull request #3022: Port view multi_key js tests into elixir test suite

Posted by GitBox <gi...@apache.org>.
wohali commented on pull request #3022:
URL: https://github.com/apache/couchdb/pull/3022#issuecomment-663246100


   Plz to keep backporting to 3.x, as we're still seeing occasional JS test suite issues there...and a 3.x release is coming up in a week or two.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org