You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/11/04 08:23:28 UTC
[GitHub] [apisix] Firstsawyou opened a new pull request #2626: fix: after proxy-mirror plugin mirroring request, the host in the mir…
Firstsawyou opened a new pull request #2626:
URL: https://github.com/apache/apisix/pull/2626
…roring request has changed.
fix #2617
### What this PR does / why we need it:
<!--- Why is this change required? What problem does it solve? -->
<!--- If it fixes an open issue, please link to the issue here. -->
### Pre-submission checklist:
* [x] Did you explain what problem does this PR solve? Or what new features have been added?
* [x] Have you added corresponding test cases?
* [ ] Have you modified the corresponding document?
* [x] Is this PR backward compatible?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander commented on a change in pull request #2626: fix: after proxy-mirror plugin mirroring request, the host in the mir…
Posted by GitBox <gi...@apache.org>.
spacewander commented on a change in pull request #2626:
URL: https://github.com/apache/apisix/pull/2626#discussion_r517174459
##########
File path: apisix/cli/ngx_tpl.lua
##########
@@ -498,6 +498,7 @@ http {
return 200;
}
+ proxy_set_header Host $upstream_host;
Review comment:
The spaces between words here is weird.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] Firstsawyou commented on a change in pull request #2626: fix: after proxy-mirror plugin mirroring request, the host in the mir…
Posted by GitBox <gi...@apache.org>.
Firstsawyou commented on a change in pull request #2626:
URL: https://github.com/apache/apisix/pull/2626#discussion_r517188607
##########
File path: apisix/cli/ngx_tpl.lua
##########
@@ -498,6 +498,7 @@ http {
return 200;
}
+ proxy_set_header Host $upstream_host;
Review comment:
Consider keeping it aligned with the line below. What do you think? Do we need to adjust?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander merged pull request #2626: fix: after proxy-mirror plugin mirroring request, the host in the mir…
Posted by GitBox <gi...@apache.org>.
spacewander merged pull request #2626:
URL: https://github.com/apache/apisix/pull/2626
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander commented on a change in pull request #2626: fix: after proxy-mirror plugin mirroring request, the host in the mir…
Posted by GitBox <gi...@apache.org>.
spacewander commented on a change in pull request #2626:
URL: https://github.com/apache/apisix/pull/2626#discussion_r517200516
##########
File path: apisix/cli/ngx_tpl.lua
##########
@@ -498,6 +498,7 @@ http {
return 200;
}
+ proxy_set_header Host $upstream_host;
Review comment:
Would be better to be aligned. It looks tidy.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] membphis commented on a change in pull request #2626: fix: after proxy-mirror plugin mirroring request, the host in the mir…
Posted by GitBox <gi...@apache.org>.
membphis commented on a change in pull request #2626:
URL: https://github.com/apache/apisix/pull/2626#discussion_r517352205
##########
File path: apisix/cli/ngx_tpl.lua
##########
@@ -498,6 +498,7 @@ http {
return 200;
}
+ proxy_set_header Host $upstream_host;
Review comment:
> Would be better to be aligned. It looks tidy.
agree
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org