You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@oozie.apache.org by "Hadoop QA (JIRA)" <ji...@apache.org> on 2011/09/08 06:27:09 UTC

[jira] [Created] (OOZIE-86) GH-46: Add support the coordiator job submitted to run in far future

GH-46: Add support the coordiator job submitted to run in far future
--------------------------------------------------------------------

                 Key: OOZIE-86
                 URL: https://issues.apache.org/jira/browse/OOZIE-86
             Project: Oozie
          Issue Type: Bug
            Reporter: Hadoop QA


The following code in PriorityDelayQueue.java class

    public int compareTo(Delayed o) {
            return (int) (getDelay(TimeUnit.MILLISECONDS) - o.getDelay(TimeUnit.MILLISECONDS));
    }

should be replace by something like this:

    public int compareTo(Delayed o) {
            long diff = (getDelay(TimeUnit.MILLISECONDS) - o.getDelay(TimeUnit.MILLISECONDS));
            if(diff > 0) {
                return 1;
             } else if(diff < 0) {
                return -1;
             } else {
                return 0;
             } 
    }

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (OOZIE-86) GH-46: Add support the coordiator job submitted to run in far future

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/OOZIE-86?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13101893#comment-13101893 ] 

Hadoop QA commented on OOZIE-86:
--------------------------------

tucu00 remarked:
Angelo,

Would you create a topical branch GH-0048 in your own repo with the patch?

Thanks.

Alejandro

> GH-46: Add support the coordiator job submitted to run in far future
> --------------------------------------------------------------------
>
>                 Key: OOZIE-86
>                 URL: https://issues.apache.org/jira/browse/OOZIE-86
>             Project: Oozie
>          Issue Type: Bug
>            Reporter: Hadoop QA
>
> The following code in PriorityDelayQueue.java class
>     public int compareTo(Delayed o) {
>             return (int) (getDelay(TimeUnit.MILLISECONDS) - o.getDelay(TimeUnit.MILLISECONDS));
>     }
> should be replace by something like this:
>     public int compareTo(Delayed o) {
>             long diff = (getDelay(TimeUnit.MILLISECONDS) - o.getDelay(TimeUnit.MILLISECONDS));
>             if(diff > 0) {
>                 return 1;
>              } else if(diff < 0) {
>                 return -1;
>              } else {
>                 return 0;
>              } 
>     }

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (OOZIE-86) GH-46: Add support the coordiator job submitted to run in far future

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/OOZIE-86?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13101895#comment-13101895 ] 

Hadoop QA commented on OOZIE-86:
--------------------------------

angelokh remarked:
Closed by 3f75f8168acbc7fbd4d1187efe0e7f496e6a2bcd Add support the coordiator job submitted to run in far future

> GH-46: Add support the coordiator job submitted to run in far future
> --------------------------------------------------------------------
>
>                 Key: OOZIE-86
>                 URL: https://issues.apache.org/jira/browse/OOZIE-86
>             Project: Oozie
>          Issue Type: Bug
>            Reporter: Hadoop QA
>
> The following code in PriorityDelayQueue.java class
>     public int compareTo(Delayed o) {
>             return (int) (getDelay(TimeUnit.MILLISECONDS) - o.getDelay(TimeUnit.MILLISECONDS));
>     }
> should be replace by something like this:
>     public int compareTo(Delayed o) {
>             long diff = (getDelay(TimeUnit.MILLISECONDS) - o.getDelay(TimeUnit.MILLISECONDS));
>             if(diff > 0) {
>                 return 1;
>              } else if(diff < 0) {
>                 return -1;
>              } else {
>                 return 0;
>              } 
>     }

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (OOZIE-86) GH-46: Add support the coordiator job submitted to run in far future

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/OOZIE-86?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13101894#comment-13101894 ] 

Hadoop QA commented on OOZIE-86:
--------------------------------

rvs remarked:
This has now been incorporated into the proposed maintenance branch 2.2. We will be sending a dedicated pull request to review commits from there when they go to master. That said, please DO  leave your feedback rvs/oozie@9453b4cc2377dbab56144e2b2dcebb9e83f78a98

> GH-46: Add support the coordiator job submitted to run in far future
> --------------------------------------------------------------------
>
>                 Key: OOZIE-86
>                 URL: https://issues.apache.org/jira/browse/OOZIE-86
>             Project: Oozie
>          Issue Type: Bug
>            Reporter: Hadoop QA
>
> The following code in PriorityDelayQueue.java class
>     public int compareTo(Delayed o) {
>             return (int) (getDelay(TimeUnit.MILLISECONDS) - o.getDelay(TimeUnit.MILLISECONDS));
>     }
> should be replace by something like this:
>     public int compareTo(Delayed o) {
>             long diff = (getDelay(TimeUnit.MILLISECONDS) - o.getDelay(TimeUnit.MILLISECONDS));
>             if(diff > 0) {
>                 return 1;
>              } else if(diff < 0) {
>                 return -1;
>              } else {
>                 return 0;
>              } 
>     }

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (OOZIE-86) GH-46: Add support the coordiator job submitted to run in far future

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/OOZIE-86?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13099784#comment-13099784 ] 

Hadoop QA commented on OOZIE-86:
--------------------------------

angelokh remarked:
XLogStreamer.FileInfo has a compareTo(). This should be taken care too.

> GH-46: Add support the coordiator job submitted to run in far future
> --------------------------------------------------------------------
>
>                 Key: OOZIE-86
>                 URL: https://issues.apache.org/jira/browse/OOZIE-86
>             Project: Oozie
>          Issue Type: Bug
>            Reporter: Hadoop QA
>
> The following code in PriorityDelayQueue.java class
>     public int compareTo(Delayed o) {
>             return (int) (getDelay(TimeUnit.MILLISECONDS) - o.getDelay(TimeUnit.MILLISECONDS));
>     }
> should be replace by something like this:
>     public int compareTo(Delayed o) {
>             long diff = (getDelay(TimeUnit.MILLISECONDS) - o.getDelay(TimeUnit.MILLISECONDS));
>             if(diff > 0) {
>                 return 1;
>              } else if(diff < 0) {
>                 return -1;
>              } else {
>                 return 0;
>              } 
>     }

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Closed] (OOZIE-86) GH-46: Add support the coordiator job submitted to run in far future

Posted by "Roman Shaposhnik (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/OOZIE-86?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Roman Shaposhnik closed OOZIE-86.
---------------------------------

    Resolution: Fixed

> GH-46: Add support the coordiator job submitted to run in far future
> --------------------------------------------------------------------
>
>                 Key: OOZIE-86
>                 URL: https://issues.apache.org/jira/browse/OOZIE-86
>             Project: Oozie
>          Issue Type: Bug
>            Reporter: Hadoop QA
>
> The following code in PriorityDelayQueue.java class
>     public int compareTo(Delayed o) {
>             return (int) (getDelay(TimeUnit.MILLISECONDS) - o.getDelay(TimeUnit.MILLISECONDS));
>     }
> should be replace by something like this:
>     public int compareTo(Delayed o) {
>             long diff = (getDelay(TimeUnit.MILLISECONDS) - o.getDelay(TimeUnit.MILLISECONDS));
>             if(diff > 0) {
>                 return 1;
>              } else if(diff < 0) {
>                 return -1;
>              } else {
>                 return 0;
>              } 
>     }

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira