[GitHub] [dubbo] AlbumenJ commented on a change in pull request #8907: Nacos unsub support and RegistryDirectory destroy

[GitBox <gi...@apache.org>]

AlbumenJ commented on a change in pull request #8907:
URL: https://github.com/apache/dubbo/pull/8907#discussion_r716598894



##########
File path: dubbo-cluster/src/main/java/org/apache/dubbo/rpc/cluster/support/wrapper/MockClusterInvoker.java
##########
@@ -75,6 +75,9 @@ public boolean isAvailable() {
 
     @Override
     public void destroy() {
+        //#8895 second question directory must destroy

Review comment:
       please remove this issue reference, just leave some description is enough

##########
File path: dubbo-registry/dubbo-registry-api/src/main/java/org/apache/dubbo/registry/integration/DynamicDirectory.java
##########
@@ -238,7 +238,8 @@ public void destroy() {
         // unsubscribe.
         try {
             if (getSubscribeConsumerurl() != null && registry != null && registry.isAvailable()) {
-                registry.unsubscribe(getSubscribeConsumerurl(), this);
+                //#8895 second question overwrite by child

Review comment:
       please remove this issue reference, just leave some description is enough




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org