You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@shenyu.apache.org by "邪龙(dragon-zhang)" <19...@qq.com.INVALID> on 2022/04/16 03:56:53 UTC

`shenyu-integrated-test-motan` always runs failed

Hello community:


I encountered a problem after submitting PR[1] which supporting shared thread pool for motan plugin.


The problem is `shenyu-integrated-test-motan` always runs failed, and&nbsp;PR [1] only adds logic related to thread pool creation.


If you are free, please see the PR[1] and help me to solve the problem.


By the way, I have tested the code in the following order:
1. run `ShenyuAdminBootstrap` and enable `MotanPlugin`;
2. run `TestMotanApplication`;
3. run `ShenyuBootstrapApplication`;
4. send post request:
GET http://localhost:9195/motan/hello
Accept: application/json
Content-Type: application/json


{
&nbsp; "name": "order"
}




thanks.
dragon-zhang


[1] https://github.com/apache/incubator-shenyu/pull/3253

回复: `shenyu-integrated-test-motan` always runs failed

Posted by "邪龙(dragon-zhang)" <19...@qq.com.INVALID>.
thanks very much !




------------------&nbsp;原始邮件&nbsp;------------------
发件人:                                                                                                                        "dev"                                                                                    <jooks@apache.org&gt;;
发送时间:&nbsp;2022年4月16日(星期六) 下午4:26
收件人:&nbsp;"dev"<dev@shenyu.apache.org&gt;;

主题:&nbsp;Re: `shenyu-integrated-test-motan` always runs failed



Hi folk,

Please update the config in `MotanPluginTest#setup`. [1]

For example :
```
"{\"register\":\"shenyu-zk:2181\",\"corethreads\":0,\"threads\":2147483647,\"queues\":0,\"threadpool\":\"cached\"}"
```

BTW, you can also add integration tests for the shared pool.

[1] https://github.com/apache/incubator-shenyu/blob/92f00e03e3fc38c987c4f539d1231da65806b396/shenyu-integrated-test/shenyu-integrated-test-motan/src/test/java/org/apache/shenyu/integrated/test/motan/MotanPluginTest.java#L39

&gt;
&gt; Hello community:
&gt;
&gt;
&gt; I encountered a problem after submitting PR[1] which supporting shared thread pool for motan plugin.
&gt;
&gt;
&gt; The problem is `shenyu-integrated-test-motan` always runs failed, and&amp;nbsp;PR [1] only adds logic related to thread pool creation.
&gt;
&gt;
&gt; If you are free, please see the PR[1] and help me to solve the problem.
&gt;
&gt;
&gt; By the way, I have tested the code in the following order:
&gt; 1. run `ShenyuAdminBootstrap` and enable `MotanPlugin`;
&gt; 2. run `TestMotanApplication`;
&gt; 3. run `ShenyuBootstrapApplication`;
&gt; 4. send post request:
&gt; GET http://localhost:9195/motan/hello
&gt; Accept: application/json
&gt; Content-Type: application/json
&gt;
&gt;
&gt; {
&gt; &amp;nbsp; "name": "order"
&gt; }
&gt;
&gt;
&gt;
&gt;
&gt; thanks.
&gt; dragon-zhang
&gt;
&gt;
&gt; [1] https://github.com/apache/incubator-shenyu/pull/3253

Re: `shenyu-integrated-test-motan` always runs failed

Posted by Kunshuai Zhu <jo...@apache.org>.
Hi folk,

Please update the config in `MotanPluginTest#setup`. [1]

For example :
```
"{\"register\":\"shenyu-zk:2181\",\"corethreads\":0,\"threads\":2147483647,\"queues\":0,\"threadpool\":\"cached\"}"
```

BTW, you can also add integration tests for the shared pool.

[1] https://github.com/apache/incubator-shenyu/blob/92f00e03e3fc38c987c4f539d1231da65806b396/shenyu-integrated-test/shenyu-integrated-test-motan/src/test/java/org/apache/shenyu/integrated/test/motan/MotanPluginTest.java#L39

>
> Hello community:
>
>
> I encountered a problem after submitting PR[1] which supporting shared thread pool for motan plugin.
>
>
> The problem is `shenyu-integrated-test-motan` always runs failed, and&nbsp;PR [1] only adds logic related to thread pool creation.
>
>
> If you are free, please see the PR[1] and help me to solve the problem.
>
>
> By the way, I have tested the code in the following order:
> 1. run `ShenyuAdminBootstrap` and enable `MotanPlugin`;
> 2. run `TestMotanApplication`;
> 3. run `ShenyuBootstrapApplication`;
> 4. send post request:
> GET http://localhost:9195/motan/hello
> Accept: application/json
> Content-Type: application/json
>
>
> {
> &nbsp; "name": "order"
> }
>
>
>
>
> thanks.
> dragon-zhang
>
>
> [1] https://github.com/apache/incubator-shenyu/pull/3253