You are viewing a plain text version of this content. The canonical link for it is here.

Posted to gitbox@activemq.apache.org by GitBox <gi...@apache.org> on 2020/03/25 03:01:48 UTC

[GitHub] [activemq-artemis] clebertsuconic commented on issue #3048: ARTEMIS-1975 Fixing LargeMessage encoding for replication

clebertsuconic commented on issue #3048: ARTEMIS-1975 Fixing LargeMessage encoding for replication
URL: https://github.com/apache/activemq-artemis/pull/3048#issuecomment-603613295
 
 
   today I have sent two commits directly into master, as I thought they were obvious change that didn't require peer review.
   
   in the process I broke org.apache.activemq.artemis.tests.integration.amqp.largemessages.AmqpReplicatedLargeMessageTest
   
   
   this is fixing AmqpReplicatedLargeMessageTest
   
   
   Instead of using a Thread local for the cache of the saved buffer, I'm storing the record on the Message.
   
   However for replication, this may be broken due to multi-threading.
   
   This is fixing that by adding reference counting.
   
   
   I did some manual testing to make sure there are no leaks. I couldn't find a way to add a permanent test without being invasive in performance.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services