You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@thrift.apache.org by "Jens Geyer (JIRA)" <ji...@apache.org> on 2013/10/14 23:03:42 UTC

[jira] [Commented] (THRIFT-2026) Fix TCompactProtocol 64 bit builds

    [ https://issues.apache.org/jira/browse/THRIFT-2026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13794476#comment-13794476 ] 

Jens Geyer commented on THRIFT-2026:
------------------------------------

+1, nice catch!

> Fix TCompactProtocol 64 bit builds
> ----------------------------------
>
>                 Key: THRIFT-2026
>                 URL: https://issues.apache.org/jira/browse/THRIFT-2026
>             Project: Thrift
>          Issue Type: Bug
>          Components: C++ - Library
>    Affects Versions: 0.9
>         Environment: Mac 64, Win 64, Linux 64
>            Reporter: Ben Craig
>            Assignee: Ben Craig
>             Fix For: 1.0
>
>         Attachments: compact_int_stuff.patch
>
>
> TCompactProtocol has several places where it truncates a size_t to a 32-bit value.
> TCompactProtocol also does bitwise operations on signed values, which has undefined behavior.



--
This message was sent by Atlassian JIRA
(v6.1#6144)