You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "dongjoon-hyun (via GitHub)" <gi...@apache.org> on 2023/01/25 19:49:10 UTC
[GitHub] [spark] dongjoon-hyun opened a new pull request, #39748: [SPARK-42190][K8S] Support `local` mode in spark.kubernetes.driver.master
dongjoon-hyun opened a new pull request, #39748:
URL: https://github.com/apache/spark/pull/39748
…
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the guideline first in
'core/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
If benchmark tests were added, please run the benchmarks in GitHub Actions for the consistent environment, and the instructions could accord to: https://spark.apache.org/developer-tools.html#github-workflow-benchmarks.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on pull request #39748: [SPARK-42190][K8S] Support `local` mode in `spark.kubernetes.driver.master`
Posted by "viirya (via GitHub)" <gi...@apache.org>.
viirya commented on PR #39748:
URL: https://github.com/apache/spark/pull/39748#issuecomment-1404481913
Yea, it could be a follow up work.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a diff in pull request #39748: [SPARK-42190][K8S] Support `local` mode in `spark.kubernetes.driver.master`
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on code in PR #39748:
URL: https://github.com/apache/spark/pull/39748#discussion_r1087372890
##########
docs/running-on-kubernetes.md:
##########
@@ -590,7 +590,8 @@ See the [configuration page](configuration.html) for information on Spark config
<td><code>spark.kubernetes.driver.master</code></td>
<td><code>https://kubernetes.default.svc</code></td>
<td>
- The internal Kubernetes master (API server) address to be used for driver to request executors.
+ The internal Kubernetes master (API server) address to be used for driver to request executors or
+ 'local[*]' for driver-pod-only mode.
Review Comment:
Sure, we can do that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #39748: [SPARK-42190][K8S] Support `local` mode in `spark.kubernetes.driver.master`
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on PR #39748:
URL: https://github.com/apache/spark/pull/39748#issuecomment-1404522121
Yeah, I am fine too :-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a diff in pull request #39748: [SPARK-42190][K8S] Support `local` mode in `spark.kubernetes.driver.master`
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on code in PR #39748:
URL: https://github.com/apache/spark/pull/39748#discussion_r1087373254
##########
resource-managers/kubernetes/integration-tests/src/test/scala/org/apache/spark/deploy/k8s/integrationtest/KubernetesSuite.scala:
##########
@@ -465,10 +465,12 @@ class KubernetesSuite extends SparkFunSuite
.get(0)
driverPodChecker(driverPod)
- // If we're testing decommissioning we an executors, but we should have an executor
- // at some point.
- Eventually.eventually(TIMEOUT, patienceInterval) {
- execPods.values.nonEmpty should be (true)
+ if (patienceInterval.value.toSeconds.toInt > 0) {
+ // If we're testing decommissioning we an executors, but we should have an executor
+ // at some point.
+ Eventually.eventually(TIMEOUT, patienceInterval) {
+ execPods.values.nonEmpty should be (true)
+ }
}
Review Comment:
Yes, previously, integration test suite assume the existence of executors. So, without this change, new test case fails after running succesfully.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #39748: [SPARK-42190][K8S] Support `local` mode in `spark.kubernetes.driver.master`
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #39748:
URL: https://github.com/apache/spark/pull/39748#issuecomment-1404500415
If you don't mind, I want to deliver this to Apache Spark 3.4 as a counter-part of [SPARK-41550 Dynamic Allocation on K8S GA](https://issues.apache.org/jira/browse/SPARK-41550), @viirya and @HyukjinKwon . As a zero-executor case, this will complete the Spark implementation in the dimension of the number of executors.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on a diff in pull request #39748: [SPARK-42190][K8S] Support `local` mode in `spark.kubernetes.driver.master`
Posted by "viirya (via GitHub)" <gi...@apache.org>.
viirya commented on code in PR #39748:
URL: https://github.com/apache/spark/pull/39748#discussion_r1087363084
##########
docs/running-on-kubernetes.md:
##########
@@ -590,7 +590,8 @@ See the [configuration page](configuration.html) for information on Spark config
<td><code>spark.kubernetes.driver.master</code></td>
<td><code>https://kubernetes.default.svc</code></td>
<td>
- The internal Kubernetes master (API server) address to be used for driver to request executors.
+ The internal Kubernetes master (API server) address to be used for driver to request executors or
+ 'local[*]' for driver-pod-only mode.
Review Comment:
Is local master URL format all supported? E.g, `local[K,F]`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on pull request #39748: [SPARK-42190][K8S] Support `local` mode in `spark.kubernetes.driver.master`
Posted by "viirya (via GitHub)" <gi...@apache.org>.
viirya commented on PR #39748:
URL: https://github.com/apache/spark/pull/39748#issuecomment-1404519049
I'm fine with this in 3.4.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun closed pull request #39748: [SPARK-42190][K8S] Support `local` mode in `spark.kubernetes.driver.master`
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun closed pull request #39748: [SPARK-42190][K8S] Support `local` mode in `spark.kubernetes.driver.master`
URL: https://github.com/apache/spark/pull/39748
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on a diff in pull request #39748: [SPARK-42190][K8S] Support `local` mode in `spark.kubernetes.driver.master`
Posted by "viirya (via GitHub)" <gi...@apache.org>.
viirya commented on code in PR #39748:
URL: https://github.com/apache/spark/pull/39748#discussion_r1087364002
##########
resource-managers/kubernetes/integration-tests/src/test/scala/org/apache/spark/deploy/k8s/integrationtest/KubernetesSuite.scala:
##########
@@ -465,10 +465,12 @@ class KubernetesSuite extends SparkFunSuite
.get(0)
driverPodChecker(driverPod)
- // If we're testing decommissioning we an executors, but we should have an executor
- // at some point.
- Eventually.eventually(TIMEOUT, patienceInterval) {
- execPods.values.nonEmpty should be (true)
+ if (patienceInterval.value.toSeconds.toInt > 0) {
+ // If we're testing decommissioning we an executors, but we should have an executor
+ // at some point.
+ Eventually.eventually(TIMEOUT, patienceInterval) {
+ execPods.values.nonEmpty should be (true)
+ }
}
Review Comment:
Is this related?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #39748: [SPARK-42190][K8S] Support `local` mode in `spark.kubernetes.driver.master`
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #39748:
URL: https://github.com/apache/spark/pull/39748#issuecomment-1404550696
Thank you all. Merged to master/3.4.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #39748: [SPARK-42190][K8S] Support `local` mode in `spark.kubernetes.driver.master`
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #39748:
URL: https://github.com/apache/spark/pull/39748#issuecomment-1404520840
Thank you so much!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a diff in pull request #39748: [SPARK-42190][K8S] Support `local` mode in `spark.kubernetes.driver.master`
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on code in PR #39748:
URL: https://github.com/apache/spark/pull/39748#discussion_r1087368805
##########
docs/running-on-kubernetes.md:
##########
@@ -590,7 +590,8 @@ See the [configuration page](configuration.html) for information on Spark config
<td><code>spark.kubernetes.driver.master</code></td>
<td><code>https://kubernetes.default.svc</code></td>
<td>
- The internal Kubernetes master (API server) address to be used for driver to request executors.
+ The internal Kubernetes master (API server) address to be used for driver to request executors or
+ 'local[*]' for driver-pod-only mode.
Review Comment:
Good point. I think we should probably leverage the same regex done in `SparkContextcreateTaskScheduler`, e.g., `LOCAL_N_REGEX`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #39748: [SPARK-42190][K8S] Support `local` mode in spark.kubernetes.driver.master
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #39748:
URL: https://github.com/apache/spark/pull/39748#issuecomment-1404455301
Could you review this PR, please, @viirya ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #39748: [SPARK-42190][K8S] Support `local` mode in `spark.kubernetes.driver.master`
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #39748:
URL: https://github.com/apache/spark/pull/39748#issuecomment-1404497928
Thank you, @viirya and @HyukjinKwon . I addressed the comments too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org