You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by GitBox <gi...@apache.org> on 2019/02/20 21:51:48 UTC

[GitHub] kinow opened a new pull request #102: TEXT-104: deprecate JaroWinkler methods for 2.0, and fix clirr report

kinow opened a new pull request #102: TEXT-104: deprecate JaroWinkler methods for 2.0, and fix clirr report
URL: https://github.com/apache/commons-text/pull/102
 
 
   This PR makes the Clirr report pass for 1.7. It keeps the new `JaroWinklerSimilarity` class, but reverts the change in `JaroWinklerDistance`. This way we keep backward feature and binary compatibility.
   
   Also added `TODO`'s in the code for 2.0, and if others are OK with this pull request, I will create a Task ticket in JIRA for 2.0, so that when a release manager performs the release, s/he won't forget to look at the TODO and update the code.
   
   @saschaszott I feel bad reverting part of your change, but it will be fully available in an upcoming 2.0 release :)
   
   Cheers
   Bruno

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org