You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/11/03 14:51:13 UTC

[GitHub] [airflow] josh-fell opened a new pull request #19383: Handle XComArg input for `bucket_name` in Google Marketing Platform operators

josh-fell opened a new pull request #19383:
URL: https://github.com/apache/airflow/pull/19383

The `GoogleCampaignManagerDownloadReportOperator`, `GoogleDisplayVideo360DownloadReportOperator`, and `GoogleSearchAdsDownloadReportOperator` perform a string validation on the `bucket_name` arg in their constructor. This arg is a templated field which means the input could be an `XComArg`. This string validation fails when the input arg for `bucket_name` is an `XComArg` with `AttributeError: 'XComArg' object has no attribute 'startswith'`.

This PR ensures that, if desired, the `bucket_name` arg can be successfully passed to these operators.

Additionally included in this PR is some DRY refactoring of the operator unit tests to use some global variables across tests.

---
**^ Add meaningful description above**

Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).

--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk commented on pull request #19383: Move `bucket_name` validation out of `init` in Google Marketing Platform operators

Posted by GitBox <gi...@apache.org>.

potiuk commented on pull request #19383:
URL: https://github.com/apache/airflow/pull/19383#issuecomment-981156181


   MSSql errors were unrelated ..


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] uranusjr commented on pull request #19383: Move `bucket_name` validation out of `init` in Google Marketing Platform operators

Posted by GitBox <gi...@apache.org>.

uranusjr commented on pull request #19383:
URL: https://github.com/apache/airflow/pull/19383#issuecomment-971360864


   LGTM, retrying tests.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] uranusjr closed pull request #19383: Move `bucket_name` validation out of `init` in Google Marketing Platform operators

Posted by GitBox <gi...@apache.org>.

uranusjr closed pull request #19383:
URL: https://github.com/apache/airflow/pull/19383


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk merged pull request #19383: Move `bucket_name` validation out of `init` in Google Marketing Platform operators

Posted by GitBox <gi...@apache.org>.

potiuk merged pull request #19383:
URL: https://github.com/apache/airflow/pull/19383


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] github-actions[bot] commented on pull request #19383: Move `bucket_name` validation out of `init` in Google Marketing Platform operators

Posted by GitBox <gi...@apache.org>.

github-actions[bot] commented on pull request #19383:
URL: https://github.com/apache/airflow/pull/19383#issuecomment-971361250


   The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org