You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2021/06/15 13:19:53 UTC
[GitHub] [maven-resolver] sirTomasson opened a new pull request #112: Mresolver 152
sirTomasson opened a new pull request #112:
URL: https://github.com/apache/maven-resolver/pull/112
Enforce non-null arguments on implementations of interfaces, by using Objects.requireNonNull.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-resolver] michael-o commented on pull request #112: Mresolver 152
Posted by GitBox <gi...@apache.org>.
michael-o commented on pull request #112:
URL: https://github.com/apache/maven-resolver/pull/112#issuecomment-864526822
All ITs pass, will merge shortly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-resolver] asfgit closed pull request #112: Mresolver 152
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #112:
URL: https://github.com/apache/maven-resolver/pull/112
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-resolver] michael-o commented on a change in pull request #112: Mresolver 152
Posted by GitBox <gi...@apache.org>.
michael-o commented on a change in pull request #112:
URL: https://github.com/apache/maven-resolver/pull/112#discussion_r654897946
##########
File path: maven-resolver-api/src/main/java/org/eclipse/aether/DefaultRepositorySystemSession.java
##########
@@ -841,6 +843,7 @@ public RemoteRepository getMirror( RemoteRepository repository )
public Authentication getAuthentication( RemoteRepository repository )
{
+ requireNonNull( repository, "repository cannot be null" );
Review comment:
I believe that this is a bug, it should return null, you change is correct though.
##########
File path: maven-resolver-api/src/main/java/org/eclipse/aether/DefaultRepositorySystemSession.java
##########
@@ -815,6 +815,7 @@ private void failIfReadOnly()
public Proxy getProxy( RemoteRepository repository )
{
+ requireNonNull( repository, "repository cannot be null" );
return repository.getProxy();
Review comment:
I believe that this is a bug, it should return null, you change is correct though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-resolver] michael-o commented on a change in pull request #112: Mresolver 152
Posted by GitBox <gi...@apache.org>.
michael-o commented on a change in pull request #112:
URL: https://github.com/apache/maven-resolver/pull/112#discussion_r654897938
##########
File path: maven-resolver-api/src/main/java/org/eclipse/aether/DefaultRepositorySystemSession.java
##########
@@ -815,6 +815,7 @@ private void failIfReadOnly()
public Proxy getProxy( RemoteRepository repository )
{
+ requireNonNull( repository, "repository cannot be null" );
return repository.getProxy();
Review comment:
I believe that this is a bug, it should return null, your change is correct though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-resolver] michael-o commented on a change in pull request #112: Mresolver 152
Posted by GitBox <gi...@apache.org>.
michael-o commented on a change in pull request #112:
URL: https://github.com/apache/maven-resolver/pull/112#discussion_r654897946
##########
File path: maven-resolver-api/src/main/java/org/eclipse/aether/DefaultRepositorySystemSession.java
##########
@@ -841,6 +843,7 @@ public RemoteRepository getMirror( RemoteRepository repository )
public Authentication getAuthentication( RemoteRepository repository )
{
+ requireNonNull( repository, "repository cannot be null" );
Review comment:
I believe that this is a bug, it should return null, your change is correct though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org