You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "kou (via GitHub)" <gi...@apache.org> on 2023/07/04 12:46:37 UTC
[GitHub] [arrow] kou opened a new pull request, #36453: GH-36449: [C++][CI] Don't use -g1 for Python jobs
kou opened a new pull request, #36453:
URL: https://github.com/apache/arrow/pull/36453
### Rationale for this change
Python jobs have tests for GDB plugin. We can't use -g1 for GDB plugin because -g1 doesn't provide enough debug information.
### What changes are included in this PR?
Don't use `-g1` for Python jobs.
### Are these changes tested?
Yes.
### Are there any user-facing changes?
No.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #36453: GH-36449: [C++][CI] Don't use -g1 for Python jobs
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #36453:
URL: https://github.com/apache/arrow/pull/36453#issuecomment-1620207792
Revision: 3c2f5e9355cebee68ef0df08e59241995993af88
Submitted crossbow builds: [ursacomputing/crossbow @ actions-3579df7be8](https://github.com/ursacomputing/crossbow/branches/all?query=actions-3579df7be8)
|Task|Status|
|----|------|
|test-cuda-python|[](https://github.com/ursacomputing/crossbow/actions/runs/5454990187/jobs/9925829481)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #36453: GH-36449: [C++][CI] Don't use -g1 for Python jobs
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #36453:
URL: https://github.com/apache/arrow/pull/36453#issuecomment-1620192654
@github-actions crossbow submit test-cuda-python test-debian-*-python-3 test-ubuntu-*-python-3 test-fedora-*-python-3
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on pull request #36453: GH-36449: [C++][CI] Don't use -g1 for Python jobs
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on PR #36453:
URL: https://github.com/apache/arrow/pull/36453#issuecomment-1620192263
@github-actions crossbow submit -g python
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] conbench-apache-arrow[bot] commented on pull request #36453: GH-36449: [C++][CI] Don't use -g1 for Python jobs
Posted by "conbench-apache-arrow[bot] (via GitHub)" <gi...@apache.org>.
conbench-apache-arrow[bot] commented on PR #36453:
URL: https://github.com/apache/arrow/pull/36453#issuecomment-1627144848
Conbench analyzed the 6 benchmark runs on commit `6f05288e`.
There were 3 benchmark results indicating a performance regression:
- Commit Run on `ursa-i9-9960x` at [2023-07-08 08:43:28Z](http://conbench.ursa.dev/compare/runs/7fc351de866b4f6d80ecffe3b6c1f308...1dfef2acd5ba4a2c9938a537e3a0c167/)
- [engine=arrow, format=native, language=R, memory_map=False, query_id=TPCH-01, scale_factor=1](http://conbench.ursa.dev/compare/benchmarks/064a90d0c180761580009c730856c0f8...064a93a54af77df68000e2a0d8a40db0)
- Commit Run on `ursa-thinkcentre-m75q` at [2023-07-06 01:33:09Z](http://conbench.ursa.dev/compare/runs/078cfb0a1eb84496a422548495772055...c6ef04156dc347c78889e482c1ed7b2c/)
- [params=<STATIC_VECTOR(int)>, source=cpp-micro, suite=arrow-small-vector-benchmark](http://conbench.ursa.dev/compare/benchmarks/064a5f01b057780c8000bdd016d4d212...064a61a16d5b77b88000ee98b8f95d1c)
- and 1 more (see the report linked below)
The [full Conbench report](https://github.com/apache/arrow/runs/14878715144) has more details.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on pull request #36453: GH-36449: [C++][CI] Don't use -g1 for Python jobs
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on PR #36453:
URL: https://github.com/apache/arrow/pull/36453#issuecomment-1620193210
Can you integrate this patch to also fix Python warnings?
```diff
diff --git a/python/pyarrow/tests/test_cuda.py b/python/pyarrow/tests/test_cuda.py
index 2ba2f8267..43cd16a3c 100644
--- a/python/pyarrow/tests/test_cuda.py
+++ b/python/pyarrow/tests/test_cuda.py
@@ -349,27 +349,29 @@ def test_HostBuffer(size):
@pytest.mark.parametrize("size", [0, 1, 1000])
def test_copy_from_to_host(size):
-
# Create a buffer in host containing range(size)
- buf = pa.allocate_buffer(size, resizable=True) # in host
+ dt = np.dtype('uint16')
+ nbytes = size * dt.itemsize
+ buf = pa.allocate_buffer(nbytes, resizable=True) # in host
assert isinstance(buf, pa.Buffer)
assert not isinstance(buf, cuda.CudaBuffer)
- arr = np.frombuffer(buf, dtype=np.uint8)
+ arr = np.frombuffer(buf, dtype=dt)
assert arr.size == size
arr[:] = range(size)
- arr_ = np.frombuffer(buf, dtype=np.uint8)
+ arr_ = np.frombuffer(buf, dtype=dt)
np.testing.assert_equal(arr, arr_)
- device_buffer = global_context.new_buffer(size)
+ # Create a device buffer of the same size and copy from host
+ device_buffer = global_context.new_buffer(nbytes)
assert isinstance(device_buffer, cuda.CudaBuffer)
assert isinstance(device_buffer, pa.Buffer)
- assert device_buffer.size == size
+ assert device_buffer.size == nbytes
assert not device_buffer.is_cpu
+ device_buffer.copy_from_host(buf, position=0, nbytes=nbytes)
- device_buffer.copy_from_host(buf, position=0, nbytes=size)
-
- buf2 = device_buffer.copy_to_host(position=0, nbytes=size)
- arr2 = np.frombuffer(buf2, dtype=np.uint8)
+ # Copy back to host and compare contents
+ buf2 = device_buffer.copy_to_host(position=0, nbytes=nbytes)
+ arr2 = np.frombuffer(buf2, dtype=dt)
np.testing.assert_equal(arr, arr2)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou merged pull request #36453: GH-36449: [C++][CI] Don't use -g1 for Python jobs
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou merged PR #36453:
URL: https://github.com/apache/arrow/pull/36453
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #36453: GH-36449: [C++][CI] Don't use -g1 for Python jobs
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #36453:
URL: https://github.com/apache/arrow/pull/36453#issuecomment-1620198529
Revision: ed0f944bff726b8b89eaa004624ec90e8e10a0c9
Submitted crossbow builds: [ursacomputing/crossbow @ actions-6858417986](https://github.com/ursacomputing/crossbow/branches/all?query=actions-6858417986)
|Task|Status|
|----|------|
|test-conda-python-3.10|[](https://github.com/ursacomputing/crossbow/actions/runs/5454918954/jobs/9925667780)|
|test-conda-python-3.10-hdfs-2.9.2|[](https://github.com/ursacomputing/crossbow/actions/runs/5454918005/jobs/9925665777)|
|test-conda-python-3.10-hdfs-3.2.1|[](https://github.com/ursacomputing/crossbow/actions/runs/5454923107/jobs/9925676567)|
|test-conda-python-3.10-pandas-latest|[](https://github.com/ursacomputing/crossbow/actions/runs/5454920684/jobs/9925671246)|
|test-conda-python-3.10-pandas-nightly|[](https://github.com/ursacomputing/crossbow/actions/runs/5454919289/jobs/9925668485)|
|test-conda-python-3.10-spark-master|[](https://github.com/ursacomputing/crossbow/actions/runs/5454918573/jobs/9925667015)|
|test-conda-python-3.10-substrait|[](https://github.com/ursacomputing/crossbow/actions/runs/5454921028/jobs/9925672137)|
|test-conda-python-3.11|[](https://github.com/ursacomputing/crossbow/actions/runs/5454921384/jobs/9925672756)|
|test-conda-python-3.11-dask-latest|[](https://github.com/ursacomputing/crossbow/actions/runs/5454922388/jobs/9925674978)|
|test-conda-python-3.11-dask-upstream_devel|[](https://github.com/ursacomputing/crossbow/actions/runs/5454916486/jobs/9925662147)|
|test-conda-python-3.11-hypothesis|[](https://github.com/ursacomputing/crossbow/actions/runs/5454922615/jobs/9925675414)|
|test-conda-python-3.11-pandas-upstream_devel|[](https://github.com/ursacomputing/crossbow/actions/runs/5454917397/jobs/9925664402)|
|test-conda-python-3.8|[](https://github.com/ursacomputing/crossbow/actions/runs/5454921771/jobs/9925673665)|
|test-conda-python-3.8-pandas-1.0|[](https://github.com/ursacomputing/crossbow/actions/runs/5454922043/jobs/9925674401)|
|test-conda-python-3.8-spark-v3.1.2|[](https://github.com/ursacomputing/crossbow/actions/runs/5454916681/jobs/9925662467)|
|test-conda-python-3.9|[](https://github.com/ursacomputing/crossbow/actions/runs/5454922906/jobs/9925676156)|
|test-conda-python-3.9-pandas-latest|[](https://github.com/ursacomputing/crossbow/actions/runs/5454916932/jobs/9925662993)|
|test-conda-python-3.9-spark-v3.2.0|[](https://github.com/ursacomputing/crossbow/actions/runs/5454920366/jobs/9925670748)|
|test-cuda-python|[](https://github.com/ursacomputing/crossbow/actions/runs/5454918323/jobs/9925666403)|
|test-debian-11-python-3|[](https://github.com/ursacomputing/crossbow/runs/14767352717)|
|test-fedora-35-python-3|[](https://github.com/ursacomputing/crossbow/tree/actions-6858417986-azure-test-fedora-35-python-3)|
|test-ubuntu-20.04-python-3|[](https://github.com/ursacomputing/crossbow/runs/14767351240)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #36453: GH-36449: [C++][CI] Don't use -g1 for Python jobs
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #36453:
URL: https://github.com/apache/arrow/pull/36453#issuecomment-1620196916
Revision: ed0f944bff726b8b89eaa004624ec90e8e10a0c9
Submitted crossbow builds: [ursacomputing/crossbow @ actions-aa45e1a934](https://github.com/ursacomputing/crossbow/branches/all?query=actions-aa45e1a934)
|Task|Status|
|----|------|
|test-cuda-python|[](https://github.com/ursacomputing/crossbow/actions/runs/5454919933/jobs/9925669956)|
|test-debian-11-python-3|[](https://github.com/ursacomputing/crossbow/runs/14767356691)|
|test-fedora-35-python-3|[](https://github.com/ursacomputing/crossbow/runs/14767358237)|
|test-ubuntu-20.04-python-3|[](https://github.com/ursacomputing/crossbow/runs/14767355016)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on pull request #36453: GH-36449: [C++][CI] Don't use -g1 for Python jobs
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on PR #36453:
URL: https://github.com/apache/arrow/pull/36453#issuecomment-1620203983
@github-actions crossbow submit test-cuda-python
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org