You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/03/10 17:46:56 UTC
[GitHub] [kafka] jeqo opened a new pull request #10294: [KAFKA-12450] Remove deprecated methods from ReadOnlyWindowStore
jeqo opened a new pull request #10294:
URL: https://github.com/apache/kafka/pull/10294
Implement first part of https://cwiki.apache.org/confluence/display/KAFKA/KIP-667%3A+Remove+deprecated+methods+from+ReadOnlyWindowStore. Preparing it for v3.0
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] guozhangwang commented on pull request #10294: KAFKA-12450: Remove deprecated methods from ReadOnlyWindowStore
Posted by GitBox <gi...@apache.org>.
guozhangwang commented on pull request #10294:
URL: https://github.com/apache/kafka/pull/10294#issuecomment-820756041
@jeqo could you rebase the PR while I review it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] guozhangwang merged pull request #10294: KAFKA-12450: Remove deprecated methods from ReadOnlyWindowStore
Posted by GitBox <gi...@apache.org>.
guozhangwang merged pull request #10294:
URL: https://github.com/apache/kafka/pull/10294
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] guozhangwang commented on pull request #10294: KAFKA-12450: Remove deprecated methods from ReadOnlyWindowStore
Posted by GitBox <gi...@apache.org>.
guozhangwang commented on pull request #10294:
URL: https://github.com/apache/kafka/pull/10294#issuecomment-832072486
Merged to trunk, thanks @jeqo
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] guozhangwang commented on a change in pull request #10294: KAFKA-12450: Remove deprecated methods from ReadOnlyWindowStore
Posted by GitBox <gi...@apache.org>.
guozhangwang commented on a change in pull request #10294:
URL: https://github.com/apache/kafka/pull/10294#discussion_r625419038
##########
File path: streams/src/main/java/org/apache/kafka/streams/state/internals/CompositeReadOnlyWindowStore.java
##########
@@ -68,10 +65,9 @@ public V fetch(final K key, final long time) {
}
@Override
- @Deprecated
public WindowStoreIterator<V> fetch(final K key,
- final long timeFrom,
- final long timeTo) {
+ final Instant timeFrom,
Review comment:
Ditto below.
##########
File path: streams/src/main/java/org/apache/kafka/streams/state/internals/CompositeReadOnlyWindowStore.java
##########
@@ -68,10 +65,9 @@ public V fetch(final K key, final long time) {
}
@Override
- @Deprecated
public WindowStoreIterator<V> fetch(final K key,
- final long timeFrom,
- final long timeTo) {
+ final Instant timeFrom,
Review comment:
Seems we are removing the `ApiUtils.validateMillisecondInstant` check here, is that intentional?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] jeqo commented on pull request #10294: KAFKA-12450: Remove deprecated methods from ReadOnlyWindowStore
Posted by GitBox <gi...@apache.org>.
jeqo commented on pull request #10294:
URL: https://github.com/apache/kafka/pull/10294#issuecomment-827844833
@guozhangwang, it should be ready for review now. thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] jeqo commented on a change in pull request #10294: KAFKA-12450: Remove deprecated methods from ReadOnlyWindowStore
Posted by GitBox <gi...@apache.org>.
jeqo commented on a change in pull request #10294:
URL: https://github.com/apache/kafka/pull/10294#discussion_r625703299
##########
File path: streams/src/main/java/org/apache/kafka/streams/state/internals/CompositeReadOnlyWindowStore.java
##########
@@ -68,10 +65,9 @@ public V fetch(final K key, final long time) {
}
@Override
- @Deprecated
public WindowStoreIterator<V> fetch(final K key,
- final long timeFrom,
- final long timeTo) {
+ final Instant timeFrom,
Review comment:
Yes, default implementation is doing this convertion already.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org