You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by bo...@apache.org on 2020/08/16 01:03:36 UTC

[beam] branch master updated: Remove redundant setMaxNumRecords and consumerFactoryFn.

This is an automated email from the ASF dual-hosted git repository.

boyuanz pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/beam.git


The following commit(s) were added to refs/heads/master by this push:
     new 2ec383d  Remove redundant setMaxNumRecords and consumerFactoryFn.
     new 31c0642  Merge pull request #12574 from boyuanzz/fix
2ec383d is described below

commit 2ec383d8d44865aedcc7954ba2381a28583f5dda
Author: Boyuan Zhang <bo...@google.com>
AuthorDate: Thu Aug 13 16:15:44 2020 -0700

    Remove redundant setMaxNumRecords and consumerFactoryFn.
---
 .../io/kafka/src/main/java/org/apache/beam/sdk/io/kafka/KafkaIO.java    | 2 --
 1 file changed, 2 deletions(-)

diff --git a/sdks/java/io/kafka/src/main/java/org/apache/beam/sdk/io/kafka/KafkaIO.java b/sdks/java/io/kafka/src/main/java/org/apache/beam/sdk/io/kafka/KafkaIO.java
index b14ef22..4ccaf66 100644
--- a/sdks/java/io/kafka/src/main/java/org/apache/beam/sdk/io/kafka/KafkaIO.java
+++ b/sdks/java/io/kafka/src/main/java/org/apache/beam/sdk/io/kafka/KafkaIO.java
@@ -572,8 +572,6 @@ public class KafkaIO {
         // Set required defaults
         setTopicPartitions(Collections.emptyList());
         setConsumerFactoryFn(KafkaIOUtils.KAFKA_CONSUMER_FACTORY_FN);
-        setMaxNumRecords(Long.MAX_VALUE);
-        setConsumerFactoryFn(KafkaIOUtils.KAFKA_CONSUMER_FACTORY_FN);
         if (config.maxReadTime != null) {
           setMaxReadTime(Duration.standardSeconds(config.maxReadTime));
         }