You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "Aias00 (via GitHub)" <gi...@apache.org> on 2026/08/12 03:00:26 UTC

[PR] feat: distinguish Proxy Local and Cluster access types [rocketmq-dashboard]

Aias00 opened a new pull request, #1950:
URL: https://github.com/apache/rocketmq-dashboard/pull/1950

   ## Summary
   
   - add explicit `PROXY_LOCAL` and `PROXY_CLUSTER` instance access types
   - retain legacy `PROXY` for persisted and cloud-managed compatibility
   - normalize new Apache `PROXY` writes to `PROXY_CLUSTER` and make the legacy filter include all Proxy variants
   - expose Local/Cluster choices, labels, endpoint guidance, and Topic context in the frontend
   - map selected instances to the matching dashboard `ClusterType`
   - update schema/API documentation and demo data
   
   ## Track
   
   RocketMQ Studio Track 1: unified control plane / multi-architecture compatibility.
   
   ## Compatibility
   
   - existing `PROXY` records remain readable
   - cloud catalog instances retain the generic `PROXY` value because their deployment topology is vendor-controlled
   - older Apache create/update requests using `PROXY` are normalized to the explicit Cluster value
   
   ## Verification
   
   - `JAVA_HOME=$(/usr/libexec/java_home -v 21) mvn -Dtest=InstanceServiceTest,MybatisPlusInstanceRepositoryTest,InstanceControllerTest,RocketMQDashboardProviderTest test` (92 tests)
   - `npm test -- --run src/pages/instance/__tests__/InstancePage.test.tsx src/pages/instance/__tests__/TopicPage.test.tsx src/services/instanceService.test.ts src/api/instance.test.ts` (32 tests)
   - `npm run build`
   - targeted ESLint for changed TypeScript files
   
   Closes #1949


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] feat: align Proxy diagnostics with deployment access types [rocketmq-dashboard]

Posted by "Aias00 (via GitHub)" <gi...@apache.org>.
Aias00 closed pull request #1950: feat: align Proxy diagnostics with deployment access types
URL: https://github.com/apache/rocketmq-dashboard/pull/1950


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] feat: align Proxy diagnostics with deployment access types [rocketmq-dashboard]

Posted by "Aias00 (via GitHub)" <gi...@apache.org>.
Aias00 commented on PR #1950:
URL: https://github.com/apache/rocketmq-dashboard/pull/1950#issuecomment-5293251796

   Rebased onto the latest `rocketmq-studio` baseline and resolved the Topic-page conflicts while preserving the current Topic-type UI and instance-deletion regression coverage.
   
   Proxy Local and Proxy Cluster access labels/descriptions now render from the normalized instance type. Verified:
   - frontend InstancePage/TopicPage tests (25 passing)
   - frontend production build
   - Java 21 `InstanceServiceTest`, `MybatisPlusInstanceRepositoryTest`, and `RocketMQDashboardProviderTest`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] feat: align Proxy diagnostics with deployment access types [rocketmq-dashboard]

Posted by "Aias00 (via GitHub)" <gi...@apache.org>.
Aias00 commented on PR #1950:
URL: https://github.com/apache/rocketmq-dashboard/pull/1950#issuecomment-5322526921

   Superseded by #2307, which consolidates this change and is CLEAN with all CI checks passing.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] feat: align Proxy diagnostics with deployment access types [rocketmq-dashboard]

Posted by "RockteMQ-AI (via GitHub)" <gi...@apache.org>.
RockteMQ-AI commented on PR #1950:
URL: https://github.com/apache/rocketmq-dashboard/pull/1950#issuecomment-5291869331

   ⚠️ **Merge conflict detected**
   
   This PR has conflicts with the base branch and cannot be merged. Please rebase or merge the base branch into your branch and resolve the conflicts:
   
   ```bash
   git fetch origin
   git checkout feat/studio-proxy-deployment-types
   git rebase origin/main
   # resolve conflicts, then:
   git push --force-with-lease
   ```
   
   This is a one-time reminder. Feel free to @mention me for a re-review after conflicts are resolved.
   
   ---
   *Automated notification by github-manager-bot*


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org