You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2019/01/14 12:58:00 UTC

[jira] [Commented] (AIRFLOW-3703) Support DnsPolicy for KubernetesPodOperator

    [ https://issues.apache.org/jira/browse/AIRFLOW-3703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16742036#comment-16742036 ] 

ASF GitHub Bot commented on AIRFLOW-3703:
-----------------------------------------

bbcbruno commented on pull request #4520: [AIRFLOW-3703] Support DnsPolicy for KubernetesPodOperator
URL: https://github.com/apache/airflow/pull/4520
 
 
   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [X] https://issues.apache.org/jira/browse/AIRFLOW-3703
   
   ### Description
   
   - [X] Here are some details about my PR, including screenshots of any UI changes:
   
   `KubernetesPodOperator` supports `hostNetwork` but sometimes in some environments it is necessary to set dnsPolicy for some pods because your cluster can use some unusual DNS configurations.
   
   This PR adds an option to set `dnsPolicy` for a pod.
   
   ### Tests
   
   - [X] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
   
   KubernetesPodOperatorTest.test_pod_dnspolicy
   
   ### Commits
   
   - [X] My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [X] In case of new functionality, my PR adds documentation that describes how to use it.
     - When adding new operators/hooks/sensors, the autoclass documentation generation needs to be added.
     - All the public functions and the classes in the PR contain docstrings that explain what it does
   
   ### Code Quality
   
   - [X] Passes `flake8`
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Support DnsPolicy for KubernetesPodOperator
> -------------------------------------------
>
>                 Key: AIRFLOW-3703
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-3703
>             Project: Apache Airflow
>          Issue Type: Wish
>          Components: kubernetes
>            Reporter: Bruno Campos
>            Priority: Minor
>
> KubernetesPodOperator supports hostNetwork but sometimes in some environments it is necessary to set dnsPolicy for some pods because your cluster can use some unusual DNS configurations.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)