You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2022/06/15 15:11:55 UTC
[GitHub] [dubbo-go-pixiu] drama10096 opened a new issue, #445: develop分支上，代码重复（完全一模一样代码）
drama10096 opened a new issue, #445:
URL: https://github.com/apache/dubbo-go-pixiu/issues/445
在pkg/adapter/dubboregistry/registry/listener.go里面有
type Listener interface {
Close()
WatchAndHandle()
}
在pkg/remote/zookeeper/client.go也有
type Listener interface {
Close()
WatchAndHandle()
}
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-pixiu] PhilYue closed issue #445: develop分支上，代码重复（完全一模一样代码）
Posted by GitBox <gi...@apache.org>.
PhilYue closed issue #445: develop分支上，代码重复（完全一模一样代码）
URL: https://github.com/apache/dubbo-go-pixiu/issues/445
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-pixiu] mark4z commented on issue #445: develop分支上，代码重复（完全一模一样代码）
Posted by GitBox <gi...@apache.org>.
mark4z commented on issue #445:
URL: https://github.com/apache/dubbo-go-pixiu/issues/445#issuecomment-1165318827
@drama10096 May u refactor it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-pixiu] PhilYue commented on issue #445: develop分支上，代码重复（完全一模一样代码）
Posted by GitBox <gi...@apache.org>.
PhilYue commented on issue #445:
URL: https://github.com/apache/dubbo-go-pixiu/issues/445#issuecomment-1212905611
@drama10096 社区已经记录了这个优化项，接下来会根据项目计划去推进重构优化代码，欢迎加入社区，有什么最新进展会在群里同步大家。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-pixiu] MasterKenway commented on issue #445: develop分支上，代码重复（完全一模一样代码）
Posted by GitBox <gi...@apache.org>.
MasterKenway commented on issue #445:
URL: https://github.com/apache/dubbo-go-pixiu/issues/445#issuecomment-1158190710
refactor needed [WIP]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-pixiu] SunnyBoy-WYH commented on issue #445: develop分支上，代码重复（完全一模一样代码）
Posted by GitBox <gi...@apache.org>.
SunnyBoy-WYH commented on issue #445:
URL: https://github.com/apache/dubbo-go-pixiu/issues/445#issuecomment-1171055349
how about move thie listener.go refactor to dir : "pkg/adapter/dubboregistry/listener.go"? so we can remove the Listener interface defined in "pkg/remote/zookeeper/client.go"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-pixiu] PhilYue commented on issue #445: develop分支上，代码重复（完全一模一样代码）
Posted by GitBox <gi...@apache.org>.
PhilYue commented on issue #445:
URL: https://github.com/apache/dubbo-go-pixiu/issues/445#issuecomment-1250231743
>
先暂时关闭了，之后会计划小重构迭代
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org