You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@lucene.apache.org by jd...@apache.org on 2012/02/28 16:53:14 UTC
svn commit: r1294703 - in /lucene/dev/trunk/solr: CHANGES.txt
core/src/java/org/apache/solr/handler/SnapShooter.java
Author: jdyer
Date: Tue Feb 28 15:53:13 2012
New Revision: 1294703
URL: http://svn.apache.org/viewvc?rev=1294703&view=rev
Log:
SOLR-3168: "numberToKeep" backups doesn't ever keep more than 1
Modified:
lucene/dev/trunk/solr/CHANGES.txt
lucene/dev/trunk/solr/core/src/java/org/apache/solr/handler/SnapShooter.java
Modified: lucene/dev/trunk/solr/CHANGES.txt
URL: http://svn.apache.org/viewvc/lucene/dev/trunk/solr/CHANGES.txt?rev=1294703&r1=1294702&r2=1294703&view=diff
==============================================================================
--- lucene/dev/trunk/solr/CHANGES.txt (original)
+++ lucene/dev/trunk/solr/CHANGES.txt Tue Feb 28 15:53:13 2012
@@ -622,6 +622,9 @@ Bug Fixes
* SOLR-2909: Add support for ResourceLoaderAware tokenizerFactories in synonym
filter factories. (Tom Klonikowski, Jun Ohtani via Koji Sekiguchi)
+
+* SOLR-3168: ReplicationHandler "numberToKeep" & "maxNumberOfBackups" parameters
+ would keep only 1 backup, even if more than 1 was specified (Neil Hooey, James Dyer)
Other Changes
----------------------
Modified: lucene/dev/trunk/solr/core/src/java/org/apache/solr/handler/SnapShooter.java
URL: http://svn.apache.org/viewvc/lucene/dev/trunk/solr/core/src/java/org/apache/solr/handler/SnapShooter.java?rev=1294703&r1=1294702&r2=1294703&view=diff
==============================================================================
--- lucene/dev/trunk/solr/core/src/java/org/apache/solr/handler/SnapShooter.java (original)
+++ lucene/dev/trunk/solr/core/src/java/org/apache/solr/handler/SnapShooter.java Tue Feb 28 15:53:13 2012
@@ -135,7 +135,7 @@ public class SnapShooter {
Collections.sort(dirs);
int i=1;
for(OldBackupDirectory dir : dirs) {
- if( i > numberToKeep-1 ) {
+ if( i++ > numberToKeep-1 ) {
SnapPuller.delTree(dir.dir);
}
}