[GitHub] [spark] cloud-fan commented on a diff in pull request #39796: [SPARK-39800][SQL][WIP] DataSourceV2: View Support

["cloud-fan (via GitHub)" <gi...@apache.org>]

cloud-fan commented on code in PR #39796:
URL: https://github.com/apache/spark/pull/39796#discussion_r1091732398


##########
sql/core/src/main/scala/org/apache/spark/sql/internal/BaseSessionStateBuilder.scala:
##########
@@ -181,9 +181,14 @@ abstract class BaseSessionStateBuilder(
    * Note: this depends on the `conf` and `catalog` fields.
    */
   protected def analyzer: Analyzer = new Analyzer(catalogManager) {
+
+    override val extendedSubstitutionRules: Seq[Rule[LogicalPlan]] =
+      Seq(ViewSubstitution(sqlParser))

Review Comment:
   why does it need to be a substitution rule? The v1 view is resolved in the main resolution batch.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org