You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@allura.apache.org by jo...@apache.org on 2012/10/19 00:32:13 UTC
[3/10] git commit: [#3883] Fix ForgeGit tests not passing and cleanup
previously left debugging leftover code.
[#3883] Fix ForgeGit tests not passing and cleanup previously left
debugging leftover code.
Signed-off-by: Peter Hartmann <ma...@gmail.com>
Project: http://git-wip-us.apache.org/repos/asf/incubator-allura/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-allura/commit/f1d2f62a
Tree: http://git-wip-us.apache.org/repos/asf/incubator-allura/tree/f1d2f62a
Diff: http://git-wip-us.apache.org/repos/asf/incubator-allura/diff/f1d2f62a
Branch: refs/heads/cj/5145
Commit: f1d2f62a351c48e790cac89fc8780e1d9ac73f6e
Parents: 449b9d2
Author: Peter Hartmann <ma...@gmail.com>
Authored: Sat Oct 6 18:16:34 2012 +0200
Committer: Cory Johns <jo...@geek.net>
Committed: Thu Oct 18 19:29:56 2012 +0000
----------------------------------------------------------------------
Allura/allura/model/repo_refresh.py | 4 ++--
Allura/allura/tests/functional/test_admin.py | 1 -
2 files changed, 2 insertions(+), 3 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/incubator-allura/blob/f1d2f62a/Allura/allura/model/repo_refresh.py
----------------------------------------------------------------------
diff --git a/Allura/allura/model/repo_refresh.py b/Allura/allura/model/repo_refresh.py
index 8b95eef..6e0db59 100644
--- a/Allura/allura/model/repo_refresh.py
+++ b/Allura/allura/model/repo_refresh.py
@@ -78,7 +78,7 @@ def refresh_repo(repo, all_commits=False, notify=True):
# Refresh trees
# Like diffs below, pre-computing trees for some SCMs is too expensive,
# so we skip it here, then do it on-demand later.
- if repo._refresh_precompute == False:
+ if repo._refresh_precompute:
cache = {}
for i, oid in enumerate(commit_ids):
ci = CommitDoc.m.find(dict(_id=oid), validate=False).next()
@@ -92,7 +92,7 @@ def refresh_repo(repo, all_commits=False, notify=True):
# are set properly for forked repos. For some SCMs, compute_diffs()
# we don't want to pre-compute the diffs because that would be too
# expensive, so we skip them here and do them on-demand with caching.
- if repo._refresh_precompute == False:
+ if repo._refresh_precompute:
for i, oid in enumerate(reversed(all_commit_ids)):
ci = CommitDoc.m.find(dict(_id=oid), validate=False).next()
compute_diffs(repo._id, cache, ci)
http://git-wip-us.apache.org/repos/asf/incubator-allura/blob/f1d2f62a/Allura/allura/tests/functional/test_admin.py
----------------------------------------------------------------------
diff --git a/Allura/allura/tests/functional/test_admin.py b/Allura/allura/tests/functional/test_admin.py
index 40cb984..c32be2e 100644
--- a/Allura/allura/tests/functional/test_admin.py
+++ b/Allura/allura/tests/functional/test_admin.py
@@ -171,7 +171,6 @@ class TestProjectAdmin(TestController):
'Chat (alpha)',
'Blog',
'Subproject']
- print tool_strings
# check using sets, because their may be more tools installed by default
# that we don't know about
assert len(set(expected_tools) - set(tool_strings)) == 0, tool_strings